Skip to content

Conversation

@rkresha
Copy link
Contributor

@rkresha rkresha commented Dec 28, 2018

@scottleibrand
Here is the re-add that shouldn't cause an issue with rpi. @cluckj would you be willing to validate this?

Adding bnep0 check back into script but writing it to the `/etc/network/interfaces.client` file instead of `/etc/network/interfaces` and doing so after the copy of `/etc/network/interfaces` to `/etc/network/interfaces.client`
Copy link
Contributor

@scottleibrand scottleibrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy to merge after testing.

@cluckj
Copy link
Contributor

cluckj commented Dec 30, 2018

👍 Tested & working as expected on the pi; thanks!

@scottleibrand
Copy link
Contributor

Do we need a test on Edison as well?

@rkresha
Copy link
Contributor Author

rkresha commented Dec 30, 2018

Do we need a test on Edison as well?

Based on my previous work on this I feel confident with the changes without actually testing them. Really your comfort level though. Please advise @scottleibrand .

Update: On second thought, I'm manually testing it.

Going to pull bnep0 out of interfaces.client, reboot, make sure bnep0 isn't in /etc/network/interfaces. Run the logic in the script to check and add to /etc/network/interfaces.client, validate it added it, reboot and make sure the changes show in /etc/network/interfaces (on the Edison)

@rkresha
Copy link
Contributor Author

rkresha commented Dec 30, 2018

@scottleibrand works as expected. Edison is good to go.

@scottleibrand scottleibrand merged commit 4127cdc into openaps:dev Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants