Webpack #1213
Merged
Webpack #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2019 19:41
scottleibrand
approved these changes
Feb 27, 2019
Contributor
scottleibrand
left a comment
scottleibrand
left a comment
There was a problem hiding this comment.
LGTM. I've never used webpack, so not sure whether/how exactly the new stuff will work, but it looks safe and backwards compatible to me, so happy to merge unless anyone else wants to do more testing first.
scottleibrand
added a commit
that referenced
this pull request
Mar 1, 2019
This commit seems to be breaking installs: https://gitter.im/nightscout/intend-to-bolus?at=5c799374c1cab53d6f5d2829 This reverts commit 2f742c6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Webpack. After running
npm run webpackvia the command line it will resolve all the dependencies needed forlib/webpack-exports.js, combine them into a single file and output that tobuild/bundle.js.This way it is a lot easier to use OpenAPS in other applications since you do not need to care about providing all the required dependencies.
For now it exports only a single function for executing Autotune which can be called by
OpenAPS.run_autotune(inputs).