Get clock from pump when offline #1287
Conversation
Another snippet from my "towards long term offline looping"-project. I had the issue when the rig was down for more than a few minutes, the missaligned clockes prevented the loop from running. Therefore I take the clock from the pump when the rig boots and is offline. That does not effect online operation as this script does nothing when wifi is connected. Also when the rig comes online again, the rig clock gets ntp syncronized and updates the pump clock at some point. Tested on my PI+HAT rig but should work for every pi based and edison based rig
|
Does this pose a race condition with oref0-pump-loop using the radio? Your sleep 60 would allow the pump-loop to start, at which point the radio would be locked, right? I know we originally put similar logic to this into oref0-pump-loop itself: not sure if that isn't working, or ? https://github.com/openaps/oref0/blob/dev/bin/oref0-pump-loop.sh#L387 |
|
Interesting! I'm absolutely sure the current code is not working since I had this clock related problem several times. But you may be right with the race condition. But without the sleep statement the Wifi connection may be still down. I'll think about it... |
|
Hi - while backpacking for a week offline the last few days, I ran into the chip clock issue big time when rig lost power and when I had to swap batteries. I am looking forward to see what you are doing! And I can confirm that this is an issue at least with the chip I was using, which was up-to-date in dev last week (there have been two new commits since then.) |
|
Actually, looking into this further, this shouldn't be able to do any harm, since setting the system clock just reads a file, and doesn't actually talk to the pump. I'm also attempting to fix this with https://github.com/openaps/oref0/tree/offline-clock-set and will let you know if that works. |
|
@scottleibrand Yes of course. I'll install it tomorrow evening. |
|
Thanks. LMK (preferably by commenting on #1290) when you've had a chance to confirm that it helps and doesn't break anything. |
|
#1290 works better |
3 participants
Another snippet from my "towards long term offline looping"-project. I had the issue when the rig was down for more than a few minutes, the missaligned clockes prevented the loop from running. Therefore I take the clock from the pump when the rig boots and is offline. That does not effect online operation as this script does nothing when wifi is connected. Also when the rig comes online again, the rig clock gets ntp syncronized and updates the pump clock at some point.
Tested on my PI+HAT rig but should work for every pi based and edison based rig