More comments #1321
Merged
More comments #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/determine-basal/determine-basal.js
Contributor
Author
|
This should be a no-op, so I'll merge tomorrow. If someone can give it a quick look over before that, even better. |
danamlewis
reviewed
Dec 4, 2019
| ci = maxCI; | ||
| } | ||
| var remainingCATimeMin = 3; // h; duration of expected not-yet-observed carb absorption | ||
| var remainingCATimeMin = 3; // h; minimum duration of expected not-yet-observed carb absorption |
Contributor
There was a problem hiding this comment.
should this comment be separated above the line to match the other comments?
Contributor
Author
There was a problem hiding this comment.
No, this is a modification to an in-line more-detailed comment, of a style I use occasionally after short variable assignment lines etc.
Contributor
|
LGTM other than one question about comment placement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more code comments giving an overview of what determine-basal is doing. Also removes some old comments and TODOs that we're never likely to do, and removes an old unused var missed in a previous cleanup.