Add public ip information to status file #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to show the public ip in my system menu on the disply and don't want to do an extra ping :) This code is tested on my pi rig with explorer-HAT (for around two weeks).
scottleibrand
approved these changes
Dec 6, 2019
bin/oref0-online.sh
Outdated
| else | ||
| echo $PUBLIC_IP | ||
| touch /tmp/hasPublicIp | ||
| echo $PUBLIC_IP > /tmp/hasPublicIp |
Contributor
There was a problem hiding this comment.
hasPublicIp was a great file name when we were treating the file as a flag, but now that we're storing the value of the IP in the file, should we rename the file to something like publicIp?
Contributor
Author
There was a problem hiding this comment.
I don't care about the exact name. I just need the feature :) So feel free to change it ;)
This file now contains the actual IP, so updating its name to better reflect that.
scottleibrand
approved these changes
Dec 15, 2019
lukaszarczynski
pushed a commit
to lukaszarczynski/oref0
that referenced
this pull request
Mar 16, 2021
This reverts commit 303833c.
lukaszarczynski
pushed a commit
to lukaszarczynski/oref0
that referenced
this pull request
Nov 4, 2025
This reverts commit 303833c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to show the public ip in my system menu on the disply and don't want to do an extra ping :)
This code is tested on my pi rig with explorer-HAT (for around two weeks).