Bugfixes #1411
Merged
Bugfixes #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a pair of config settings for low-battery shutdown thresholds. One config setting is for Edison (denominated in millivolts), the other is for Pi (given as percentage). This config setting is needed for USB-powered Pi rigs, where the battery level indicator just returns a random number, which might occasionally be zero.
This is mainly for convenience during development; a checkout in some weird branch doesn't necessarily return success when you "git pull", but that doesn't necessarily mean you want to abort oref0-runagain.sh.
Depending on the initial contents of sshd_config, this would sometimes try to add a line to it, but instead completely overwrite it to contain only that line.
On Pi Zero hardware, these tests would sometimes time out because starting the nodejs interpreter is slow (even with a fixed nodejs interpreter). Extend the timeout to 4s, from the default of 2s, so they pass.
This was referenced Nov 14, 2021
Contributor
scottleibrand
left a comment
scottleibrand
left a comment
There was a problem hiding this comment.
Added a couple of minor comments
Contributor
|
I have run the part that updates the node manually, and indeed start up time is much shorter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant changes:
pi_battery_shutdown_percentandedison_battery_shutdown_voltage, for controlling when the rig shuts down due to low battery. This config setting is needed for USB-powered Pi rigs, where the battery level indicator just returns a random number, which might occasionally be zero.Minor changes:
oref0-runagain.sh. This is mainly for convenience during development; a checkout in some weird branch doesn't necessarily return success when you "git pull".