Move Edison refs to Explorer IF/Then section #622
Conversation
An attmept to reduce problems on Pi based rigs by moving Edison references to the Explorer If/Then section of the setup.
PieterGit
left a comment
PieterGit
left a comment
There was a problem hiding this comment.
The crontab lines must be in the crontab context of the oref0-setup.sh. Otherwise if the users cleans the crontab, the EdisonVoltage stuff won't enabled if the users lets oref0-setup.sh clear the crontab.
scottleibrand
left a comment
scottleibrand
left a comment
There was a problem hiding this comment.
This would preemptively install Edison stuff even before the user says Y to continue with the install. We instead need to do so after that prompt, based on the ttyport containing spidev5.1.
|
Changed methodology. Added if statements and a global explorer1 variable to track whether install is done on an Explorer or not. I'm sure there's a better way? But I think this should fix the concerns/observations noted by Pieter and Scott above. |
|
Ready to merge this to dev as soon as someone tests it (or is ready to do so in dev). |
3 participants
An attmept to reduce problems on Pi based rigs by moving Edison references to the Explorer If/Then section of the setup. Also edited openaps-install.sh to add a user check for user edison before attempting to adduser edison to sudo and dialout groups. Please take a close look at this as this is my first attempt at modifying code and using the Github workflow.