Make remainingCI time responsive to temp targets #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with the new bilinear /\ shaped carb absorption curve, some meals spike more quickly than the assumed 4h, so it would be better to provide the user a way to tell the system that an upcoming meal is likely to be fast-absorbing, and allow oref1 to more aggressively SMB for the predicted rise.
To do so, this change adjusts the duration of the /\ remainingCI absorption curve to be shorter (3h) when a temp target of 80 is set, and longer for a high temp target (5h for 120, 6h for 140, etc.). This gives the user more control over how aggressive they want SMB to be for carbs that have been entered but aren't yet absorbing.