Project remaining carb absorption time based on % carbs absorbed #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… seeing absorption
Contributor
Author
|
Ready to merge this if no objections. @danamlewis ? |
danamlewis
approved these changes
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently 0.6.0-dev relies on the user to set an eating soon to reduce the remaining carb absorption time for not-yet-absorbing carbs from 4h to 3h. However, what we really want is for it to assume the shorter absorption timeframe when carbs are first entered, but not assume quick absorption at the tail end if actual absorption is not being observed.
This change makes the remainingCATime a function of what % of entered carbs have been absorbed vs. remain as COB. When the carbs are first absorbed, remainingCATime is set to 3 hours. At 50%, it'll use 4h. And as COB approaches zero, remainingCATime will approach 5 hours.
This also disables the previous behavior of changing remainingCATime based on temp targets.