don't run loop if rig is too hot #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a rig is getting too hot, we should pause pump-loop and ns-loop (the two that drive most CPU activity) until the rig cools off, while printing error messages in pump-loop.log to inform the user they need to better ventilate their rig. This will allow the rig to set temps at least occasionally, rather than getting to the Edison's critical temperature alarm threshold and rebooting (or presumably shutting down hard at some point).
This has been tested on a well-insulated overheating Edison rig by pulling the updated oref0-online and manually updating openaps.ini. We'll also need to make sure that the alias.json change doesn't break anything, and that checking
sensorsdoesn't break anything on Pi rigs that don't have it.