Blend minGuardBG #698
Merged
Blend minGuardBG #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using a hard cutoff of 75% of carbs to switch minGuardBG over from COBpredBGs to UAMpredBGs, this calculates a minGuardBG for each of COB, UAM, and IOB, and blends the minCOBGuardBG and minUAMGuardBG according to what % of carbs have absorbed. This allows oref0 to be less aggressive (particularly with SMBs) when carbs are overestimated or CR is too low and UAMpredBGs are running much lower than COBpredBGs.
@PieterGit this one might also be helpful for you.