Attempting to --nogit by default for existing user installs #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice. We should also test it on a rig that's already had .git removed. It will probably whine about being unable to remove .git - we'll need to decide if that's clear enough, or if we need to redirect the output of |
Contributor
|
@scottleibrand I'll rerun it now...want me to just try a runagain? went ahead and did runagain on this same rig...here's how it looked.
|
Contributor
|
Ok, good. No scary warnings. :-) Thanks. |
scottleibrand
approved these changes
Oct 6, 2017
Contributor
Author
|
WOOT. Thanks @Kdisimone for testing it both ways! |
Contributor
|
no worries. installed fine both ways. and YEAH for nogit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the amazing @Kdisimone as always for the first round of testing, confirmed it successfully installs and removes an existing git directory.
Looks like this after starting setup:
And then it successfully removed .git
For anyone else who wants to test:
cd ~/myopenapsandls -la(you should see .git listed in the alphabetical list - we need this tested on rigs that still have git)cd ~/src/oref0/ && git fetch && git checkout no-git-default && git pullnpm run global-installbash ~/myopenaps/oref0-runagain.shls -laagain inmyopenapsand confirm that .git no longer exists there.(If you're planning to stay on this branch vs. switching back to dev, make sure to re-set your preferences!)