Update existential subquery CIP #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

hvub merged 53 commits into opencypher:master from hvub:update-existential-subquery-cip

Jun 15, 2021

Contributor

hvub commented Jun 7, 2021 •

edited

Loading

This PR updates CIP2015-05-13 EXISTS (rendered view and in conjunction the grammar as well as TCK scenarios.

More specifically, the PR

Adds a production for ExistentialSubquery
Adds the ExistentialSubquery as alternative to Atom
Renames the CaseAlternatives to CaseAlternative, since is represent only a single alternative
Reuse the Where in the production PatternComprehension
Removes feature on graph element property existence tests (Graph9 — as a consequence, Graph10 becomes Graph9)) and map field existence tests (Map4)
Replaces exists(<X>) with <X> IS NOT NULL on remaining occurrences in TCK scenarios
Adds/extends scenarios on <X> IS [NOT] NULL in Null1 and Null2
Adds/extends scenarios on property/field access in Graph6 and Map1
Add scenarios to on property/field existence test with ... IN keys(...) to Graph8 and Map3

hvub added the NOT READY FOR REVIEW label

hvub force-pushed the update-existential-subquery-cip branch from 4dc23f7 to cfca711 Compare

June 8, 2021 20:49

hvub added 21 commits

June 9, 2021 11:07


          Remove EXISTS as a function name

3ea3b53


          Remove EXISTS as a function name

76226dd


          Add production ExistentialSubquery

ab43947


          Add non-terminal ExistentialSubquery as alternative to Atom

e76ad49


          Rename CaseAlternatives to CaseAlternative

c6c4caa


          Reuse <Where> in <PatternComprehension> for more consistency

62b48e0


          First draft updating the CIP

0eb3b60


          Fix grammar ambiguity bug


          Turn exists(map.field) into map.field IS NOT NULL

0f97ded


          Turn exists(map.field) into map.field IS NOT NULL

32aefb8


          Turn exists(map.field) into map.field IS NOT NULL

e7782cb


          Turn exists(...) into ... IS NOT NULL

ede07fb


          Turn exists(...) into ... IS NOT NULL

9a9150c


          Turn exists(...) into ... IS NOT NULL

e29d795


          Turn exists(...) into ... IS NOT NULL

4950b42


          Refine wording, fixing some typos and formatting

e199365


          not use existsas variable name (reserved word)

12dbb9f


          RelationshipsPattern -> RelationshipPattern

5a2b853


          editorials and new grammar linking

9b53e94


          RelationshipPattern -> RelationshipsPattern

248e3ce


          RelationshipPattern -> RelationshipsPattern

4e87bde

hvub force-pushed the update-existential-subquery-cip branch from 97fabf4 to 4e87bde Compare

June 9, 2021 09:08

hvub added 6 commits

June 10, 2021 09:05


          move "IS NOT NULL is case insensitive" scenarios

31a0bef


          Add/extend scenarios testing IS [NOT] NULL on maps

91f9d22


          Add/extend scenarios testing map field access with regards to null an…

f994d19

…d case sensitivity


          Remove Map4 - Field existence check (no dedicate functionality anym…

75c24aa

…ore)


          Add scenario for property/field existence check via keys() and IN

5ec66f6


          bug fix

3b424e3

hvub mentioned this pull request

existential pattern match #492

Merged

Mats-SX requested changes

View reviewed changes

Member

Mats-SX left a comment

A very comprehensive rework, impressive!

I found a few typos that we should fix before merge. Also one comment on TCK correctness.

There are also some suggestions to improve understandability, which are optional.

Thanks a lot for this!

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated Show resolved Hide resolved

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated Show resolved Hide resolved

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated Show resolved Hide resolved

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated Show resolved Hide resolved

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated Show resolved Hide resolved

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Show resolved Hide resolved

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Show resolved Hide resolved

grammar/basic-grammar.xml Show resolved Hide resolved

grammar/basic-grammar.xml Show resolved Hide resolved

tck/features/expressions/graph/Graph9.feature Outdated Show resolved Hide resolved

hvub and others added 16 commits

June 11, 2021 16:04


          accept suggestion from review

9dfa6e3

Co-authored-by: Mats Rydberg <[email protected]>


          Update cip/1.accepted/CIP2015-05-13-EXISTS.adoc

16d844e

accept suggestion from review

Co-authored-by: Mats Rydberg <[email protected]>


          accept suggestion from review

0410a1a

Co-authored-by: Mats Rydberg <[email protected]>


          accept suggestion from review

3c18456

Co-authored-by: Mats Rydberg <[email protected]>


          accept suggestion from review

eab2366

Co-authored-by: Mats Rydberg <[email protected]>


          accept suggestion from review

961affb

Co-authored-by: Mats Rydberg <[email protected]>


          accept suggestion from review

bf40a94

Co-authored-by: Mats Rydberg <[email protected]>


          accept suggestion from review

caa90a4

Co-authored-by: Mats Rydberg <[email protected]>


          accept suggestion from review

d7676fd

Co-authored-by: Mats Rydberg <[email protected]>


          accept suggestion from review

e2434ad

Co-authored-by: Mats Rydberg <[email protected]>


          add commas to grammar in cip

27579e6


          accept suggestion from review

72144e3

Co-authored-by: Mats Rydberg <[email protected]>


          accept suggestion from review

c423671

Co-authored-by: Mats Rydberg <[email protected]>


          fix wording

a842a3b


          fix wording

3fef5ba


          add informative note

5dc1466

sherfert reviewed

View reviewed changes

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated Show resolved Hide resolved

Mats-SX approved these changes

View reviewed changes

Member

Mats-SX commented Jun 14, 2021

@hvub Great improvements! Thanks a lot for addressing my comments.

sherfert reviewed

View reviewed changes

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated

    
              Both are allowed as https://raw.githack.com/openCypher/openCypher/master/tools/grammar-production-links/grammarLink.html?p=Atom[<Atom>]s of expressions.

              Note that a <RelationshipsPattern> appearing in an expression is evaluated to a list of paths containing the matches of the pattern.

sherfert Jun 15, 2021

Is <RelationshipsPattern> supposed to be a link like below? (Twice in this paragraph)

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated

    
              Further, https://raw.githack.com/openCypher/openCypher/master/tools/grammar-production-links/grammarLink.html?p=PatternComprehension[<PatternComprehension>] offer a more powerful and syntactically better separated means to get lists of matches for a pattern within expressions.

              The understanding of subqueries in Cypher has evolved and Cypher gained a proper https://raw.githack.com/openCypher/openCypher/master/tools/grammar-production-links/grammarLink.html?p=NullOperatorExpression[<NullOperatorExpression>] (`IS [ NOT ] NULL`), cf. https://github.com/opencypher/openCypher/blob/master/cip/1.accepted/CIP2018-10-29-EXISTS-and-IS-NOT-NULL.adoc[CIP2018-10-29 EXISTS and IS NOT NULL].

              Both developments and the issues around <RelationshipsPattern>s suggest the need for a refinement of the language constructs that allow testing of existence.

sherfert Jun 15, 2021

Is <RelationshipsPattern> supposed to be a link?

Contributor Author

hvub Jun 15, 2021

I have added the links.

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated Show resolved Hide resolved

cip/1.accepted/CIP2015-05-13-EXISTS.adoc Outdated Show resolved Hide resolved

hvub and others added 4 commits

June 15, 2021 09:43


          Accept suggestion

a5c6c36

Co-authored-by: Satia Herfert <[email protected]>


          Accept suggestion

Co-authored-by: Satia Herfert <[email protected]>


          Add missing links

f256b3a


          Add missing place allowing a naked pattern

cd9bf2f

sherfert approved these changes

View reviewed changes

sherfert left a comment

Looking great!

hvub merged commit 7a452bd into opencypher:master

hvub deleted the update-existential-subquery-cip branch

June 15, 2021 11:33

Mats-SX added a commit to Mats-SX/openCypher that referenced this pull request


          Update grammar definition

1f1be12

- use same EBNF style as @hvub did in opencypher#493
- use links to connect to grammar constructs in openCypher grammar spec
- modify constraint operators to be suffix-modeled, ala IS NOT NULL
- introduce 'grouped-expression' concept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels