acid-block | Replace pkg_resources to importlib_resources | Drop support for python 3.8 #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- transitioned from pkg_resources api to importlib-resources api
- Drop support for python 3.8 and add support for python 3.11 and 3.12
ttqureshi
force-pushed
the
ttqureshi/depr_pkg_resources
branch
from
e2c2d54 to
5b98078
Compare
feanil
approved these changes
Sep 27, 2024
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Please bump the version so we can also do a new release.
Member
Author
ok 👍 |
farhan
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
pkg_resourcesapi fromimportlib_resourcesapipython 3.8and add support forpython 3.11Tickets:
Followed this migration guide.
Testing
I have tested the changes against the following steps:
acid-blocktoxblock-sdk.Screenshots
XBlock Acid single block testXBlock Acid Parent test