fix: Install pip and pip-tools in upgrade script #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
reviewed
Jun 21, 2022
requirements/pip.txt
Outdated
| pip==22.1.2 | ||
| # via -r requirements/pip.in | ||
| setuptools==59.5.0 | ||
| setuptools==62.4.0 |
Member
There was a problem hiding this comment.
pip.in needs to have constraints file check in it so it can keep the setuptools version pinned.
Jawayria
force-pushed
the
jawayria/fix-upgrade
branch
from
e0607ee to
98d50b9
Compare
UsamaSadiq
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the upgrade target script to check the compatibility of upgraded pip and pip-tools versions.
For reference, look at this PR for new check added in edx-repo-health.
JIRA: https://2u-internal.atlassian.net/browse/BOM-3446