-
Notifications
You must be signed in to change notification settings - Fork 299
feat: improved accessibility of notification tray #1817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
filippovskii09
wants to merge
7
commits into
openedx:master
Choose a base branch
from
raccoongang:filippovskii/feat/course-unit-notifications-tray
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+785
−29
Draft
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
220d14e
feat: improved accessibility of notification tray
filippovskii09 c6fc88b
fix: upgrate test coverage & fix disccusion & some refactor
filippovskii09 8eb8ab0
fix: fix lint errors
filippovskii09 5199cee
fix: remove extra comments & add description for handleKeyDown
filippovskii09 217a46c
fix: refactor after review
filippovskii09 d23f8a2
fix: some refactor
filippovskii09 ca3a43c
fix: some formating and refactor
filippovskii09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: remove extra comments & add description for handleKeyDown
- Loading branch information
commit 5199cee319e77e561218c0e65fc33373ca3d7cf5
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,3 @@ | ||||||
| // hooks/useSidebarFocusAndKeyboard.test.js (або .jsx) | ||||||
| import { renderHook, act } from '@testing-library/react'; | ||||||
| import SidebarContext from '../../SidebarContext'; | ||||||
| import { useSidebarFocusAndKeyboard } from './useSidebarFocusAndKeyboard'; | ||||||
|
|
@@ -165,7 +164,6 @@ describe('useSidebarFocusAndKeyboard', () => { | |||||
| }); | ||||||
|
|
||||||
| expect(mockEvent.preventDefault).toHaveBeenCalledTimes(1); | ||||||
| // Перевіряємо фокус тригера | ||||||
| act(() => { jest.runAllTimers(); }); | ||||||
|
||||||
| act(() => { jest.runAllTimers(); }); | |
| act(() => jest.runAllTimers()); |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added this custom hook
useSidebarFocusAndKeyboard.jsto separate the logic which we added in this PRbecause a lot of logic interfered with orientation in the component