Skip to content

feat: Certificate Status marked up as a heading level 2 #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
filippovskii09 wants to merge 4 commits into
base: master
Choose a base branch
from
+7 −1
Draft

feat: Certificate Status marked up as a heading level 2 #1835

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e339c1
feat: Certificate Status marked up as a heading level 2
filippovskii09 Dec 1, 2025
8106ccb
fix: fix test falls
filippovskii09 Dec 1, 2025
784f0af
fix: remove extra file and remove extra lines
filippovskii09 Dec 9, 2025
43de14d
fix: remove extra line
filippovskii09 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix test falls
  • Loading branch information
@filippovskii09
filippovskii09 committed Dec 1, 2025
commit 8106ccb432d00646630cd09a344dad2925b67bc5
4 changes: 4 additions & 0 deletions src/courseware/course/Course.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ describe('Course', () => {
global.innerWidth = breakpoints.extraLarge.minWidth;
});

beforeEach(() => {
sessionStorage.clear();
});

Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just clarifying. Do we really need this here?

// This was passing when it shouldn't have been because of improper
// waitFor use. With the React 18 upgrade it no longer improperly passes
// so we are skipping it. See https://github.com/openedx/frontend-app-learning/issues/1669
Expand Down