Skip to content

feat: improved accessibility skipping to main content #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
filippovskii09 wants to merge 4 commits into
base: master
Choose a base branch
from
+347 −20
Draft

feat: improved accessibility skipping to main content #1836

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f8069d
feat: improved accessibility skipping to main content
filippovskii09 Dec 1, 2025
6214e8f
fix: some refactor and fixes
filippovskii09 Dec 2, 2025
1d9c217
fix: add translation for screenReaderText attr
filippovskii09 Dec 7, 2025
c2441ae
fix: resolve linter errors
filippovskii09 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: some refactor and fixes
  • Loading branch information
@filippovskii09
filippovskii09 committed Dec 2, 2025
commit 6214e8fcd3458a19510aea5464de1df4ccf5e8b6
2 changes: 1 addition & 1 deletion src/course-home/dates-tab/DatesTab.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { sendTrackEvent } from '@edx/frontend-platform/analytics';
import { useIntl } from '@edx/frontend-platform/i18n';

import { MAIN_CONTENT_ID } from '@src/constants';
import { useScrollToContent } from '@src/generic/hooks';
import messages from './messages';
import Timeline from './timeline/Timeline';

Expand All @@ -14,7 +15,6 @@ import SuggestedScheduleHeader from '../suggested-schedule-messaging/SuggestedSc
import ShiftDatesAlert from '../suggested-schedule-messaging/ShiftDatesAlert';
import UpgradeToCompleteAlert from '../suggested-schedule-messaging/UpgradeToCompleteAlert';
import UpgradeToShiftDatesAlert from '../suggested-schedule-messaging/UpgradeToShiftDatesAlert';
import { useScrollToContent } from '../../generic/hooks';

const DatesTab = () => {
const intl = useIntl();
Expand Down
5 changes: 3 additions & 2 deletions src/courseware/course/sequence/sequence-navigation/UnitButton.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
waitFor,
} from '../../../../setupTest';
import UnitButton from './UnitButton';
import messages from './messages';

describe('Unit Button', () => {
let mockData;
Expand Down Expand Up @@ -112,7 +113,7 @@ describe('Unit Button', () => {
const { container } = render(
<>
<UnitButton {...mockData} />
<button id="bookmark-button" type="button">Bookmark</button>
<button id="bookmark-button" type="button">{messages.bookmark.defaultMessage}</button>
</>,
{ wrapWithRouter: true },
);
Expand All @@ -136,7 +137,7 @@ describe('Unit Button', () => {
const { container } = render(
<>
<UnitButton {...mockData} onClick={onClick} />
<button id="bookmark-button" type="button">Bookmark</button>
<button id="bookmark-button" type="button">{messages.bookmark.defaultMessage}</button>
</>,
{ wrapWithRouter: true },
);
Expand Down
5 changes: 5 additions & 0 deletions src/courseware/course/sequence/sequence-navigation/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ const messages = defineMessages({
defaultMessage: 'Previous',
description: 'Button to return to the previous section',
},
bookmark: {
id: 'learning.generic.bookmark',
defaultMessage: 'Bookmark',
description: 'Button text for bookmarking',
},
});

export default messages;
4 changes: 2 additions & 2 deletions src/generic/hooks.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('Hooks', () => {
test('should scroll to target element and focus', async () => {
render(<TestComponent />);

const skipLink = screen.getByRole('link', { name: /skip to content/i });
const skipLink = screen.getByRole('link', { name: new RegExp(messages.skipToContent.defaultMessage, 'i') });
const targetContent = screen.getByTestId('target-content');

targetContent.focus = jest.fn();
Expand Down Expand Up @@ -114,7 +114,7 @@ describe('Hooks', () => {

render(<ComponentWithoutTarget />);

const skipLink = screen.getByRole('link', { name: /skip to content/i });
const skipLink = screen.getByRole('link', { name: new RegExp(messages.skipToContent.defaultMessage, 'i') });

await userEvent.click(skipLink);

Expand Down