Add @parity/electron #14
Conversation
Pull Request Test Coverage Report for Build 113
💛 - Coveralls |
| // testRegex: 'spec\\.(ts|tsx)$' // TODO Skip api/ tests for now, as it's still WIP | ||
| testRegex: 'packages/(abi|light.js|light.js-react)/.*spec\\.(ts|tsx)$' | ||
| testRegex: | ||
| 'packages/(abi|electron|light.js|light.js-react)/.*spec\\.(ts|tsx)$' |
There was a problem hiding this comment.
still missing escaping the dot for light.js and light.js-react but it doesn't make a difference for all intents and purposes ^^
| * Spawns a child process to run Parity. | ||
| */ | ||
| export async function runParity( | ||
| options: RunParityOptions = { |
There was a problem hiding this comment.
needs to be verified but I think that for example onParityError would be undefined if we just pass as argument to runParity {flags: []}
There was a problem hiding this comment.
Ah yes, you're right.
| */ | ||
| export async function fetchParity( | ||
| mainWindow: BrowserWindow, | ||
| options: FetchParityOptions = { |
There was a problem hiding this comment.
ditto cf openethereum/fether@752ec5f
I think if we just call fetchParity({parityChannel: 'stable'}) it would crash because onProgress will be undefined and the function will try to call it
| * @ignore | ||
| * @return Promise<string> - Resolves to a string which is the command to run parity. | ||
| */ | ||
| const doesParityExist = async () => { |
There was a problem hiding this comment.
just thought that the function could probably be rewritten as return isParityInPath().catch(isParityInOs).catch(isParityInUserData).catch(e => { throw new Error('Parity not found')}
| logger = _logger; | ||
| }; | ||
|
|
||
| export default () => logger; |
There was a problem hiding this comment.
fwiw I think we could export default logger directly
No description provided.