This repository was archived by the owner on May 24, 2022. It is now read-only.
refactor: Fixes #42. Use console.warn for when offline so log is yellow with warning icon #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
suggested changes
Nov 12, 2018
Collaborator
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
registerServiceWorker.js is a file auto-generated by create-react-app, I prefer not to touch it.
Does #42 address the console.logs in the library, or only in the example? If in the whole library, then this is not the correct file to modify.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.