This repository was archived by the owner on May 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Use TS strict mode #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 246
💛 - Coveralls |
axelchalon
reviewed
Nov 23, 2018
packages/abi/src/encoder/encoder.ts
Outdated
|
|
||
| static encodeToken (token: Token, index = 0): Mediate { | ||
| if (!isInstanceOf(token, Token)) { | ||
| static encodeToken (token?: Token, index = 0): Mediate { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason we're using the token?: Token syntax to define an optional parameter here, and we're using the ParamType[] | undefined syntax in the other file?
also out of curiosity, why are we setting the first parameter of encode and encodeToken as optional if they really are required?
axelchalon
reviewed
Nov 23, 2018
packages/contracts/src/badgereg.ts
Outdated
| resultIcon = null; | ||
| } | ||
|
|
||
| return { title, icon }; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to return { title, icon: resultIcon } here?
axelchalon
reviewed
Nov 23, 2018
packages/abi/src/encoder/encoder.ts
Outdated
|
|
||
| class Encoder { | ||
| static encode (tokens: Token[]) { | ||
| static encode (tokens?: Token[]) { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
axelchalon
approved these changes
Nov 23, 2018
Contributor
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use strict mode in tsconfig.
This PR is easier read commit by commit.