-
Notifications
You must be signed in to change notification settings - Fork 38
ws transport: fix for node env without global window #72
Conversation
|
It looks like @pluswave hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
can't sign CLA. there is a bug in that site. |
|
It looks like @pluswave hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks, just a small change.
Could you rebase also against the latest master, it should make Travis happy.
(we'll figure out CLA later on)
packages/api/src/transport/ws/ws.js
Outdated
| }, 5000); | ||
|
|
||
| window._parityWS = this; | ||
| if(typeof window != 'undefined') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!==
|
@pluswave can you please signup via https://cla.parity.io now - thanks |
494f937 to
2f3d424
Compare
No description provided.