Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

WIP: Relates to #81. Update to Electron v3.1.0 #90

Closed
ltfschoen wants to merge 4 commits into from
Closed

WIP: Relates to #81. Update to Electron v3.1.0 #90

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bd8d8f
feat: Relates to #81. Update to Electron v3.1.0
ltfschoen Jan 9, 2019
8b347e0
fix: Add version to NPM package.json
ltfschoen Jan 9, 2019
73c2042
fix: Update dependencies. See commit details
ltfschoen Jan 9, 2019
2e2d809
review-fix: Updates based on review comments so far
ltfschoen Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Add version to NPM package.json 
Otherwise when try to use the package from a remote branch such as
```
"@parity/electron": "https://github.com/paritytech/js-libs.git#luke-81-electron-3",
```
Then it produces error:
```
error Can't add "@parity/electron": invalid package version undefined.
```
  • Loading branch information
@ltfschoen
ltfschoen committed Jan 9, 2019
commit 8b347e047c260e53f3da0955bf87bb2c10de2744
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "js-libs",
"description": "A collection of JavaScript libraries for dapp development.",
"version": "v3.0.26",
Copy link
Collaborator

@amaury1093 amaury1093 Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to have version on the root package.json, see for example babel

Copy link
Contributor Author

@ltfschoen ltfschoen Jan 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I pushed my changes in this branch 'luke-81-electron-3' of js-libs repo without a version number in its package.json, then when I tried to test using this remote branch in a branch of Fether 'luke-309-electron-3' on this line of code https://github.com/paritytech/fether/pull/349/files#diff-52ba44750a2113719866b7d98b31af30R42 "@parity/electron": "https://github.com/paritytech/js-libs.git#luke-81-electron-3",, I found that when I tried to build Fether with yarn; yarn start it would give me an error that it required a version number in the package.json file

Copy link
Contributor Author

@ltfschoen ltfschoen Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It produced the following:

error Can't add "@parity/electron": invalid package version undefined.

In the details of the commit message I included the full log 8b347e0

"author": "Parity Team <[email protected]>",
"maintainers": [
"Amaury Martiny"
Expand Down