Skip to content

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Sep 19, 2025

Moving to open a number of graphics related tests, originally written to test the OpenGL pipeline.
These versions are "better behaved" than the versions that were in closed - mostly meaning they now
do things on the right thread and paint properly on demand.
As a result they now pass - at least on systems with correct drivers etc.
There are a few bugs to add to the issue list which I'll do right after submitting this.

I also extended these tests so as to run with the default pipeline on every system, not just OpenGL.
This mostly went OK except that I found one of the tests fails on macOS with metal.
I've had to add a new problem listing for that.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27399/head:pull/27399
$ git checkout pull/27399

Update a local copy of the PR:
$ git checkout pull/27399
$ git pull https://git.openjdk.org/jdk.git pull/27399/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27399

View PR using the GUI difftool:
$ git pr show -t 27399

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27399.diff

@prrace
Copy link
Contributor Author

prrace commented Sep 19, 2025

/issue add 8164487,8237245,8297094,8328098,8325761,8358058

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8040230 8040230: Sep 19, 2025
@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@prrace The issue 8164487 was not found in the JDK project - make sure you have entered it correctly.
The issue 8297094 was not found in the JDK project - make sure you have entered it correctly.
The issue 8328098 was not found in the JDK project - make sure you have entered it correctly.
The issue 8325761 was not found in the JDK project - make sure you have entered it correctly.
The issue 8358058 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@prrace prrace changed the title 8040230: 8040230 Sep 19, 2025
@openjdk openjdk bot changed the title 8040230 8040230: Sep 19, 2025
@prrace
Copy link
Contributor Author

prrace commented Sep 19, 2025

/issue add 8164487,8237245,8297094,8328098,8325761,8358058

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@prrace The issue 8164487 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant