Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to open a number of graphics related tests, originally written to test the OpenGL pipeline.
These versions are "better behaved" than the versions that were in closed - mostly meaning they now
do things on the right thread and paint properly on demand.
As a result they now pass - at least on systems with correct drivers etc.
There are a few bugs to add to the issue list which I'll do right after submitting this.
I also extended these tests so as to run with the default pipeline on every system, not just OpenGL.
This mostly went OK except that I found one of the tests fails on macOS with metal.
I've had to add a new problem listing for that.
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27399/head:pull/27399
$ git checkout pull/27399
Update a local copy of the PR:
$ git checkout pull/27399
$ git pull https://git.openjdk.org/jdk.git pull/27399/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27399
View PR using the GUI difftool:
$ git pr show -t 27399
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27399.diff