Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 22, 2025

Hi all,

This pull request contains a backport of commit fe29cad5 from the openjdk/jdk repository.

The commit being backported was authored by Brent Christian on 6 May 2025 and was reviewed by Kim Barrett and Jaikiran Pai.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8298783 needs maintainer approval

Issue

  • JDK-8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3869/head:pull/3869
$ git checkout pull/3869

Update a local copy of the PR:
$ git checkout pull/3869
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3869/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3869

View PR using the GUI difftool:
$ git pr show -t 3869

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3869.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e4bea56: 8365913: Support latest MSC_VER in abstract_vm_version.cpp
  • 4511370: 8353957: Open source several AWT ScrollPane tests - Batch 1
  • f5db238: 8352793: Open source several AWT TextComponent tests - Batch 1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fe29cad5e0b10cd088fc39967599f5a8dcaa445c 8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" Aug 22, 2025
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 22, 2025
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 22, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to make test more robustness which fix the test fails intermittent. Change has been verifiled locally on linux-x64. Test-fix only, risk is low.

@sendaoYan
Copy link
Member Author

I have merge the master, try to fix the other test failure.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@sendaoYan
8298783: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant