Skip to content

8368475: [lworld] Add preview classes to jimage at make time #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

8368475: [lworld] Add preview classes to jimage at make time #1622

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d7f5f3
jimage writer changes to support preview mode.
david-beaumont Sep 23, 2025
e84e7a8
Remove TODOs now jimage version is bumped
david-beaumont Sep 23, 2025
eb2752a
add system property guard to preview mode
david-beaumont Sep 23, 2025
f29bdbe
Restoring lost changes and updating some comments.
david-beaumont Sep 23, 2025
09ca4c6
new tests for ImageLocation
david-beaumont Oct 9, 2025
b566ea1
[[AUTOMATIC FORMATTING]]
david-beaumont Oct 10, 2025
bde94b6
feedback and remove unused code
david-beaumont Oct 10, 2025
dbd78c3
Fixing up after dependent PR changes
david-beaumont Oct 24, 2025
c1f4189
fixing tests after refactoring
david-beaumont Oct 29, 2025
b32d27c
Roll up of makefile and test fix (temporary)
david-beaumont Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing up after dependent PR changes
  • Loading branch information
@david-beaumont
david-beaumont committed Nov 3, 2025
commit dbd78c33ac1a7a61ef90b55a1cae339c2746af37
8 changes: 4 additions & 4 deletions test/jdk/tools/jlink/whitebox/jdk.jlink/jdk/tools/jlink/internal/ImageResourcesTreeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,25 +237,25 @@ static void assertContainsResources(Node dirNode, String... resourceNames) {

static void assertNonEmptyRef(ModuleReference ref, String modName) {
assertEquals(modName, ref.name(), "Unexpected module name: " + ref);
assertTrue(ref.hasContent(), "Expected non-empty reference: " + ref);
assertTrue(ref.hasResources(), "Expected non-empty reference: " + ref);
assertFalse(ref.isPreviewOnly(), "Expected not preview-only: " + ref);
}

static void assertEmptyRef(ModuleReference ref, String modName) {
assertEquals(modName, ref.name(), "Unexpected module name: " + ref);
assertFalse(ref.hasContent(), "Expected empty reference: " + ref);
assertFalse(ref.hasResources(), "Expected empty reference: " + ref);
assertFalse(ref.isPreviewOnly(), "Expected not preview-only: " + ref);
}

static void assertNonEmptyPreviewOnlyRef(ModuleReference ref, String modName) {
assertEquals(modName, ref.name(), "Unexpected module name: " + ref);
assertTrue(ref.hasContent(), "Expected empty reference: " + ref);
assertTrue(ref.hasResources(), "Expected empty reference: " + ref);
assertTrue(ref.isPreviewOnly(), "Expected preview-only: " + ref);
}

static void assertEmptyPreviewOnlyRef(ModuleReference ref, String modName) {
assertEquals(modName, ref.name(), "Unexpected module name: " + ref);
assertFalse(ref.hasContent(), "Expected empty reference: " + ref);
assertFalse(ref.hasResources(), "Expected empty reference: " + ref);
assertTrue(ref.isPreviewOnly(), "Expected preview-only: " + ref);
}
}