Merge lworld #1688
Draft
Merge lworld #1688
+452,282
−446,932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed-by: epeter, dlong
Reviewed-by: smarks, weijun
Reviewed-by: naoto
… aarch64 Co-authored-by: Martin Doerr <[email protected]> Reviewed-by: mdoerr, aph, eosterlund
…thread_state Reviewed-by: mdoerr, dholmes
…t index is a variable Reviewed-by: shade, xgong, epeter
… never be zero" with -Xint and COH Reviewed-by: fparain
Reviewed-by: dholmes, stefank, kvn, adinn, jsjolen
Reviewed-by: kbarrett
Reviewed-by: azvegint
Reviewed-by: dlong, epeter
…alized Windows platform Reviewed-by: dholmes, alanb
…va after current merges of JDK-8352737 and JDK-8366705 Reviewed-by: thartmann, dsimms
…o compile after mis-merge Reviewed-by: shade, alanb
…ng null for loop back address Reviewed-by: msheppar, djelinski, jpai
Reviewed-by: erikj
Reviewed-by: erikj
Reviewed-by: erikj
Reviewed-by: dsimms
…mes fails Reviewed-by: dfuchs, jpai
…mpressedOops Reviewed-by: aboldtch, tschatzl
…s and class linking Reviewed-by: dholmes, amenkov, coleenp
Reviewed-by: stefank
Reviewed-by: jsjolen, dholmes
Reviewed-by: dholmes, simonis, kevinw
…ncurrent class loadings Reviewed-by: dsimms
…lure Reviewed-by: fparain
…ssignment javac tests
… this() invocation Reviewed-by: liach
Reviewed-by: thartmann
…rict instance fields Reviewed-by: chagedorn
Reviewed-by: thartmann
…rtedClassVersionError Reviewed-by: dsimms, rriggs
…elds with initializers in the prologue Reviewed-by: liach
…truction.java Reviewed-by: thartmann
Co-authored-by: Stefan Karlsson <[email protected]> Reviewed-by: chagedorn
…erating TestMismatchHandling.jcod Reviewed-by: thartmann
…fields in the calling convention Reviewed-by: thartmann
Reviewed-by: rriggs
…to separate @test blocks Reviewed-by: thartmann, phubner
Reviewed-by: coleenp, fparain, thartmann
|
👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
jatin-bhateja
force-pushed
the
merge_lworld2
branch
from
516660f to
8b1efdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
56 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge from lworld in lworld+vector branch.
Apart from the usual merge conflict resolution, the patch also contains bug fixes for some special handling around multifields.
To segregate the code changes and maintain the history[1][2][3][4][5], these bug fixes were initially checked into a temporary private merge branch and are now part of the merge.
Validation: Status
[1] Special copy constructor used for initializing base and synthetic multifields
jatin-bhateja@0fe3153
[2] Fix ciField population for multifields
jatin-bhateja@4a26aff
[3] Multifield handling during type domain buildup
jatin-bhateja@74ca024
[4] prevent store forwarding across CPU memory barrier
jatin-bhateja@cfc71ac
[5] Fix to accommodate additional padding during offset computation of multifields
jatin-bhateja@75ec629
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1688/head:pull/1688$ git checkout pull/1688Update a local copy of the PR:
$ git checkout pull/1688$ git pull https://git.openjdk.org/valhalla.git pull/1688/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1688View PR using the GUI difftool:
$ git pr show -t 1688Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1688.diff