-
Notifications
You must be signed in to change notification settings - Fork 127
8370450: [lworld] Alternate implementation of the substitutability test method #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
23c2ccd
Add alternate version of the substitutability method
fparain 893afdc
Merge remote-tracking branch 'upstream/lworld' into new_acmp
fparain c4d5cf4
Apply changes suggested in review
fparain 22b7404
Merge remote-tracking branch 'upstream/lworld' into new_acmp
fparain 661ffa7
More fixes uggested in reviews
fparain cf456a9
Remove useless check
fparain f5f7448
Add comment
fparain e9e79fe
Add comment
fparain 52959d0
Field to field map must be final
fparain 99f2114
Merge remote-tracking branch 'upstream/lworld' into new_acmp
fparain 899f480
Fix behavior when alt method is not used
fparain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge remote-tracking branch 'upstream/lworld' into new_acmp
- Loading branch information
commit 893afdc6d65864bf6069aa1bf6aa421c51848ff6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need this flag on/off for core-libs tests in addition to runtime tests.