8370951: [lworld] Value record ClassCircularityError

[Arraying]

Hi all,

When we encounter situations where we can't preload, for example if two value classes refer to each other, may not be able to do flattening as we cannot compute the field layout. We have log messages as a hint to application or library developers to let them know of that fact. They are very useful for debugging. However, retaining them at the warning level means they are shown by default. This may be misleading, as seeing e.g. ClassCircularityError in a log may indicate that something has gone gravely wrong, which is not the case with preload failures. This PR relegates all preload failure logs to level info, such that the information is opt-in and will not unnecessarily cause confusion.

Testing: tier 1.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8370951: [lworld] Value record ClassCircularityError (Bug - P3)

Reviewers

• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1710/head:pull/1710
$ git checkout pull/1710

Update a local copy of the PR:
$ git checkout pull/1710
$ git pull https://git.openjdk.org/valhalla.git pull/1710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1710

View PR using the GUI difftool:
$ git pr show -t 1710

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1710.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phubner! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Arraying This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370951: [lworld] Value record ClassCircularityError

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the lworld branch:

• 7b5f105: 8370484: [lworld] PhaseOutput::FillLocArray asserts with Unexpected type: anyptr
• 88f413d: [lworld] Don't run TestMethodHandles.java with -Xcomp
• a6d6cb8: [lworld] Disable assert until JDK-8350208 is fixed in mainline
• ... and 3 more: https://git.openjdk.org/valhalla/compare/a60678c089387f1a72f176008f9bfef9fcad947b...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (86dd4bcb)

[fparain]

LGTM.

[Arraying]

Thanks for the review @fparain.
/integrate

[openjdk]

@Arraying
Your change (at version 86dd4bc) is now ready to be sponsored by a Committer.

[MrSimms]

/sponsor

[openjdk]

Going to push as commit f638741.
Since your change was applied there have been 6 commits pushed to the lworld branch:

• 7b5f105: 8370484: [lworld] PhaseOutput::FillLocArray asserts with Unexpected type: anyptr
• 88f413d: [lworld] Don't run TestMethodHandles.java with -Xcomp
• a6d6cb8: [lworld] Disable assert until JDK-8350208 is fixed in mainline
• ... and 3 more: https://git.openjdk.org/valhalla/compare/a60678c089387f1a72f176008f9bfef9fcad947b...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@MrSimms @Arraying Pushed as commit f638741.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.