Skip to content

Conversation

@stefank
Copy link
Member

@stefank stefank commented Dec 9, 2025

Minimal builds on x86 fail because some new functions have been defined inside a COMPILER2_OR_JVMCI block. I've moved the code so that the three clear_mem functions are kept together and alone in their COMPILER2_OR_JVMCI block.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8373346: [lworld] Linking error on x64 with minimal build (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1780/head:pull/1780
$ git checkout pull/1780

Update a local copy of the PR:
$ git checkout pull/1780
$ git pull https://git.openjdk.org/valhalla.git pull/1780/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1780

View PR using the GUI difftool:
$ git pr show -t 1780

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1780.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2025

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 9, 2025

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373346: [lworld] Linking error on x64 with minimal build

Reviewed-by: phubner, heidinga, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • cfd3a72: 8373259: [lworld] Remove BufferedValueClosure

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2025

Webrevs

Copy link
Contributor

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2025
@stefank stefank changed the title 8373346: [lworld] Link error on x64 with minimal build 8373346: [lworld] Linking error on x64 with minimal build Dec 9, 2025
@stefank
Copy link
Member Author

stefank commented Dec 9, 2025

Thanks for the reviews. This passed tier1 testing.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 9, 2025
@openjdk
Copy link

openjdk bot commented Dec 9, 2025

@stefank
Your change (at version 35ca873) is now ready to be sponsored by a Committer.

@fparain
Copy link
Collaborator

fparain commented Dec 9, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 9, 2025

Going to push as commit 30ef92b.
Since your change was applied there have been 2 commits pushed to the lworld branch:

  • 6e15674: 8373347: [lworld] Minor cleanups in the memory directory
  • cfd3a72: 8373259: [lworld] Remove BufferedValueClosure

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 9, 2025
@openjdk openjdk bot closed this Dec 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 9, 2025
@openjdk
Copy link

openjdk bot commented Dec 9, 2025

@fparain @stefank Pushed as commit 30ef92b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants