Skip to content

Conversation

@ManojLL
Copy link
Contributor

@ManojLL ManojLL commented Jan 16, 2024

Description of what I changed

replace hibernate xml mappings with annotations and removed relevant xml file.

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5951

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@ManojLL
Copy link
Contributor Author

ManojLL commented Jan 16, 2024

@dkayiwa While resolving merge conflicts in the previous PR I lost the changes I had implemented and PR got closed. I have now reopened a new pull request for the same issue, TRUNK-5951.

@dkayiwa dkayiwa merged commit ed85bd2 into openmrs:master Jan 16, 2024
Wandji69 pushed a commit to Wandji69/openmrs-core that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants