TRUNK-5837: Migrate Cohort Domain from Hibernate Mapping XML to JPA annotations. #4892
Conversation
|
@ManojLL @wikumChamith Can you review this please? |
|
@wikumChamith i made the changes. can you approve the workflow please? |
|
@dilankavishka are you still working on this? |
|
@dkayiwa @wikumChamith @ManojLL I think this PR is good to go right? |
|
@dilankavishka do you mind resolving the merge conflicts? |
|
@dkayiwa Resolved. Please approve the workflow |
|
@dilankavishka can you fix the JIRA ticket link? |
@dkayiwa Sorry for the mistake. I Fixed that |
| } | ||
|
|
||
| public void setMemberships(Collection<CohortMembership> members) { | ||
| this.memberships = members; |
There was a problem hiding this comment.
This is something minor. Do we need the space here :) ?
|
@dilankavishka do you mind resolving the merge conflicts? |
| @Column(name = "name", nullable = false) | ||
| private String name; | ||
|
|
||
| @Column(name = "description", nullable = false) |
| @Column(name = "cohort_id", nullable = false) | ||
| private Integer cohortId; | ||
|
|
||
| @Column(name = "name", nullable = false) |
There was a problem hiding this comment.
Did you just forget to specify the length as was in the xml mapping file?
| @Test | ||
| public void getCommaSeparatedPatientIds_shouldReturnCommaSeparatedListOfPatients() { | ||
|
|
||
| List<Patient> patients = new ArrayList<>(); |
There was a problem hiding this comment.
Was this change required as part of the ticket?
|
@dilankavishka are you still working on this? |
4 participants
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-5837
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master