Fix Path Traversal and XSS Security Vulnerabilities Detected by SpotBugs #5546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnasambu
suggested changes
Dec 10, 2025
| // clear the module messages | ||
| String messagesPath = realPath + "/WEB-INF/"; | ||
| File folder = new File(messagesPath.replace("/", File.separator)); | ||
| // Normalize separators |
Contributor
There was a problem hiding this comment.
Kindly the comments here don’t seem to add extra value so it would be better to remove them and rely on the code readability instead.
| // Normalize separators | ||
| String safePath = messagesPath.replace("/", File.separator); | ||
|
|
||
| // Detect basic path traversal patterns |
| File moduleWebFolder = new File(absPath.replace("/", File.separator)); | ||
| String absPath = realPath + "/WEB-INF/web/module/" + moduleId; | ||
|
|
||
| // normalize path separator |
Contributor
There was a problem hiding this comment.
Same here. Kindly remove all the comments that starts with //.
|
|
||
| addLogLinesToResponse(result); | ||
| } | ||
Contributor
There was a problem hiding this comment.
Is there away you can fix the format changes please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple security vulnerabilities detected by SpotBugs Security in the OpenMRS Core codebase.
Changes include:
These changes eliminate all reported warnings under:
Security → Potential Path Traversal (file read)
Security → Potential XSS in Servlet
Security → Potential SQL Injection