TRUNK-5852 : Provider Domain - Switching from Hibernate Mappings to Annotations

[Debbielou]

TRUNK-5852

Description of what I changed

Updated Provider class with annotations, deleted the Provider hbm file, deleted the Provider reference in hibernate cfg file, added the annotated Provider class to OrderServiceTest.

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5852

Checklist: I completed these to help reviewers :)

• [ x] My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• [x ] I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.

  No? -> execute above command

• All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[Debbielou]

On translating the xml to Java annotations for the Provider domain, I am getting a few test failures with this specific error. My suspicion is that the default fallback is null where name does not exist in the Provide class getName() method. @dkayiwa kindly advise on this. Thanks.

[dkayiwa]

@Debbielou in order to fix the not null errors for name, you need to add something like this: @AttributeOverrides({ @AttributeOverride(name = "name", column = @Column(name = "name", nullable = true)) })