TRUNK-5902: CohortMembership Domain - Switching from Hibernate Mappings to Annotations #5568
+30
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs to Annotations
shivvani-r
force-pushed
the
TRUNK-5902
branch
from
e5ee677 to
3efc070
Compare
dkayiwa
reviewed
Dec 7, 2025
| @Id | ||
| @Column(name = "cohort_member_id") | ||
| @GeneratedValue(generator = "native") | ||
| @GenericGenerator( |
Member
There was a problem hiding this comment.
Let us just use identity as done here: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/Diagnosis.java#L56
Author
There was a problem hiding this comment.
Thanks for the pointer! I've switched it to GenerationType.IDENTITY and confirmed that the tests still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
I have migrated the
CohortMembershipdomain object from legacy Hibernate XML mappings to standard JPA annotations.Specific changes include:
@Entity,@Table,@Column, etc.) toCohortMembership.java.GenerationType.IDENTITYstrategy.@AttributeOverrideand@AssociationOverrideto map the inheriteddateChangedandchangedByfields todate_createdandcreator(read-only). This resolves schema validation errors because the legacycohort_membertable lacks modification tracking columns.CohortMembership.hbm.xmlfile.hibernate.cfg.xmlto reference the annotated class instead of the XML resource.Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-5902
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.