(feat) O3-5020: Add a review & approval workflow for lab results configurable #445

its-kios09 · 2025-09-10T21:53:39Z

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
My work includes tests or is validated by existing tests.

Summary

As a laboratory technician/manager, I want to have the ability to review lab results before they are finalized, so that I can ensure quality control and accuracy of test results before they become available to clinicians.

global configuration

{
  "enableReviewingLabResultsBeforeApproval": true  
}

Screenshots

Related Issue

https://openmrs.atlassian.net/browse/O3-5020

Other

…rendering - Add enableReviewingLabResultsBeforeApproval config option - Implement dual workflow in LabResultsForm (ON_HOLD vs COMPLETED) - Add conditional rendering for pending review tabs and tiles - Hide edit results action when approval workflow is enabled - Maintain backward compatibility with existing workflow Components updated: - LabResultsForm: merged workflows with conditional logic - LaboratoryOrdersTabs: conditional pending review tab - LaboratorySummaryTiles: conditional pending review tile - OrdersDataTable: conditional edit results menu item

ESLint was treating '__dirname' as a string literal in the JSON config. Removed it since 'project': true handles tsconfig discovery automatically.

package.json

.eslintrc

src/index.ts

src/lab-tabs/data-table-extensions/pending-review-lab-request-table.extension.tsx

src/config-schema.ts

…y-app into O3-5020

its-kios09 · 2025-10-28T17:22:43Z

@pirupius I Believe we are okay now

its-kios09 · 2025-10-28T17:25:53Z

@chibongho @ibacher ping

pirupius

Some minor clean ups before we get this in. Also don't forget to push the updated lock file once you've updated the package.json

src/components/orders-table/list-order-details.component.tsx

.github/workflows/e2e.yml

package.json

jabahum · 2025-10-29T14:34:50Z

@its-kios09 lets resolve conflicts

pirupius

Please add these lines after Install dependencies in to the e2e.yml to resolve the e2e error

  - name: 🎭 Install Playwright Browsers
    run: npx playwright install --with-deps chromium

its-kios09 · 2025-10-30T11:58:45Z

@pirupius sorted

chibongho · 2025-10-30T02:13:35Z

src/types.ts

+  type OrderUrgency,
+  type OrderAction as ExternalOrderAction,
+} from '@openmrs/esm-patient-common-lib';
+export type FulfillerStatus = 'DRAFT' | 'RECEIVED' | 'IN_PROGRESS' | 'EXCEPTION' | 'ON_HOLD' | 'DECLINED' | 'COMPLETED';


The FulfillerStatus enum does not have "DRAFT" as a valid value. Do we plan on adding that to the backend? @pirupius @its-kios09

@chibongho i believe he made that change after this comment #445 (comment) from Ian but the part am not sure about is if it needs an extra configuration or update to esm-core

@chibongho I think we should update the backend to support correct FulfillerStatus enum as Draft as @ibacher suggest ^IMO

@chibongho I have this PR on adding the enum openmrs/openmrs-core#5447 maybe you can see some light

chibongho · 2025-10-30T02:59:04Z

src/lab-tiles/laboratory-summary-tiles.component.tsx


+  const filteredExtensions = tilesExtensions
+    .filter((extension) => Object.keys(extension.meta).length > 0)
+    .filter((extension) => {


Is this test code?

@chibongho Thanks, I didn't see it I have done a follow up PR for it #532

denniskigen · 2025-12-02T09:04:48Z

Isn't it more appropriate to default this config property to false? Otherwise, we're making assumptions about implementations wanting to have this review and approval workflow enabled out of the box. The canonical pattern with these configuration options is always to default to having them turned off and let implementations opt-in if they want to @its-kios09 @pirupius.

denniskigen · 2025-12-02T09:14:57Z

I've pushed a commit here making the behaviour opt-in by default ecc7701.

pirupius · 2025-12-02T09:51:07Z

I agree @denniskigen thanks for the quick fix.

its-kios09 mentioned this pull request Sep 10, 2025

(feat) O3-5020: Add a review & approval workflow for lab results configurable openmrs/openmrs-esm-patient-chart#2737

Open

3 tasks

pirupius requested review from chibongho, denniskigen, ibacher and pirupius September 11, 2025 16:11

its-kios09 and others added 10 commits September 15, 2025 18:46

Merge branch 'main' into O3-5020

b07f98c

(fix) Build issues

b8f05b4

(fix) Fixed the Build issue

bc13edd

Merge branch 'main' into O3-5020

3e378dd

(refactor) Updated the yarn.lock

9b66255

Merge branch 'main' into O3-5020

1e6eff7

(fix) Build issues

7ac9f90

fix: remove invalid tsconfigRootDir from ESLint config

5c33940

ESLint was treating '__dirname' as a string literal in the JSON config. Removed it since 'project': true handles tsconfig discovery automatically.

chore: upgrade TypeScript to v5.0 for const type parameter support

17e9ba9

fix: ensure Playwright browsers are always installed in CI

eb2cb67

ibacher requested changes Oct 6, 2025

View reviewed changes

its-kios09 and others added 5 commits October 16, 2025 10:14

(refactor) Updated the PR suggestions

227fefe

Merge branch 'main' into O3-5020

9fcb1f3

(refactor) Updated the PR suggestions

e64d1a6

Merge branch 'O3-5020' of github.com:its-kios09/openmrs-esm-laborator…

669f916

…y-app into O3-5020

Merge remote changes

ba7905e

its-kios09 requested a review from ibacher October 16, 2025 09:52

its-kios09 and others added 7 commits October 20, 2025 12:25

Merge branch 'main' into O3-5020

a02377b

(refactor) fix the yarn.lock

ba863a8

(refactor) fix the yarn.lock

db95f63

(refactor) fix the yarn.lock

a804286

(refactor) fix the yarn.lock

a8d465d

(refactor) fix the yarn.lock

4d04674

(refactor) refactor the type

0146797

its-kios09 and others added 8 commits October 28, 2025 19:37

(fix) Fix build issues

9bbf4df

(fix) Fix build issues

5bd470a

(fix) Fix build issues

c29e9eb

(fix) Fix build issues

96bfd0d

(fix) Fix build issues

8484f36

(fix) Fix build issues

df211d1

Merge branch 'main' into O3-5020

e3dbda6

chore: update yarn.lock

55c5b7d

pirupius reviewed Oct 29, 2025

View reviewed changes

src/components/orders-table/list-order-details.component.tsx Outdated Show resolved Hide resolved

.github/workflows/e2e.yml Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

its-kios09 and others added 4 commits October 29, 2025 18:42

(refactor) Address PR suggestion

05a1f30

(refactor) Address PR suggestion

c1dea02

Merge branch 'main' into O3-5020

44ec442

(refactor) Address PR suggestion

08ccb36

its-kios09 requested a review from pirupius October 29, 2025 15:58

pirupius reviewed Oct 30, 2025

View reviewed changes

its-kios09 and others added 2 commits October 30, 2025 14:41

Merge branch 'main' into O3-5020

ba2644e

(fix) fixed e2e yml playwright issues installation

d79cb97

its-kios09 requested a review from pirupius October 30, 2025 11:58

Merge branch 'main' into O3-5020

bd3edb6

pirupius approved these changes Oct 30, 2025

View reviewed changes

pirupius merged commit a969a94 into openmrs:main Oct 30, 2025
5 checks passed

chibongho reviewed Oct 30, 2025

View reviewed changes

chibongho mentioned this pull request Oct 30, 2025

TRUNK-6462: (feat) Align FulfillerStatus enum with FHIR Task Status codes on platform 3.x openmrs/openmrs-core#5447

Open

5 tasks

(feat) O3-5020: Add a review & approval workflow for lab results configurable #445

(feat) O3-5020: Add a review & approval workflow for lab results configurable #445

Uh oh!

Conversation

its-kios09 commented Sep 10, 2025 • edited by denniskigen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Requirements

Summary

Screenshots

Related Issue

Other

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

its-kios09 commented Oct 28, 2025

Uh oh!

its-kios09 commented Oct 28, 2025

Uh oh!

pirupius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jabahum commented Oct 29, 2025

Uh oh!

pirupius left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

its-kios09 commented Oct 30, 2025

Uh oh!

Uh oh!

chibongho Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

pirupius Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

its-kios09 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

its-kios09 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

chibongho Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

its-kios09 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

denniskigen commented Dec 2, 2025

Uh oh!

denniskigen commented Dec 2, 2025

Uh oh!

pirupius commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

its-kios09 commented Sep 10, 2025 •

edited by denniskigen

Loading

pirupius left a comment •

edited

Loading