lua buffers

[bakins]

I have a branch that use lua buffers instead of malloc/free in build_query:

https://github.com/bakins/lua-redis-parser/tree/lua_buffers

I did it as an example of buffers for myself, but feel free to use it or not.

[agentzh]

On Sat, Feb 4, 2012 at 4:32 AM, Brian Akins
reply@reply.github.com
wrote:

I have a branch that use lua buffers instead of malloc/free in build_query:

https://github.com/bakins/lua-redis-parser/tree/lua_buffers

I did it as an example of buffers for myself, but feel free to use it or not.

Thanks for the work. Have you done any benchmarks for this? Like
number of CPU cycles involved and memory footprint?

Thanks!
-agentzh

[bakins]

On Feb 4, 2012, at 1:43 AM, agentzh (章亦春) wrote:

Thanks for the work. Have you done any benchmarks for this? Like
number of CPU cycles involved and memory footprint?

I have not done any benchmarks, Like I said I did it just for some practice. I generally don't like to mix malloc/free in with my Lua stuff when there is a "Lua way" to do something. I can mock up some benchmarks, shouldn't be too hard. I noticed there is a slight possibility of a leak in the malloc/free version which I think using buffers doesn't have.

[agentzh]

On Sat, Feb 4, 2012 at 10:24 PM, Brian Akins
reply+i-3088408-45a730c7cc0f6d690431a7528cd9155ac9a1ca40-56241@reply.github.c

I have not done any benchmarks, Like I said I did it just for some practice.  I generally don't like to mix malloc/free in with my Lua stuff when there is a "Lua way" to do something.  I can mock up some benchmarks, shouldn't be too hard.  I noticed there is a slight possibility of a leak in the malloc/free version which I think using buffers doesn't have.

Fair enough :)

-agentzh

[bakins]

silly little benchmark branch: https://github.com/bakins/lua-redis-parser/tree/benchmark_build_query

On my machine with the benchmark in that branch, the malloc version is about twice as fast. I am a little surprised.

[bakins]

No need to pull. was a good exercise for me, though.