travis ci support, some cosmetic improvements #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chipitsine
commented
May 23, 2016
chipitsine
commented
(*) removed "upstream keepalive module" since modern nginx supports that natively (*) changed memcached regex
| --- request | ||
| GET /ver | ||
| --- response_body_like: ^VERSION \d+(\.\d+)+\S*?\r\n$ | ||
| --- response_body_like: ^VERSION \d+(\.\d+)+.*?\r\n$ |
There was a problem hiding this comment.
Could you make these changes a separate PR? I hope PRs are self-contained. Thank you very much!
There was a problem hiding this comment.
@chipitsine I can do the split myself this time. Please use atomic PRs next time. Thanks!
agentzh
added a commit
that referenced
this pull request
May 23, 2016
…butions may patch memcached and give it fancy version numbers (like Ubuntu). thanks Ilya Shipitsin for the patch in #24.
agentzh
added a commit
that referenced
this pull request
May 23, 2016
…ce it is already in recent nginx cores. thanks Ilya Shipitsin for the patch in #24.
agentzh
added a commit
that referenced
this pull request
May 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.