Skip to content

bugfix: sizeof('c')=4, not 1, fix overallocations. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

bugfix: sizeof('c')=4, not 1, fix overallocations. #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/ngx_http_memc_request.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ ngx_http_memc_create_flush_all_cmd_request(ngx_http_request_t *r)
if (!exptime_vv->not_found && exptime_vv->len) {
dd("found exptime: %s", exptime_vv->data);

len += sizeof(' ') + exptime_vv->len;
len += sizeof(" ") - 1 + exptime_vv->len;
}

len += sizeof(CRLF) - 1;
Expand Down Expand Up @@ -451,12 +451,12 @@ ngx_http_memc_create_delete_cmd_request(ngx_http_request_t *r)
return NGX_HTTP_INTERNAL_SERVER_ERROR;
}

len = ctx->cmd_str.len + sizeof(' ') + key_vv->len + escape;
len = ctx->cmd_str.len + sizeof(" ") - 1 + key_vv->len + escape;

if (!exptime_vv->not_found && exptime_vv->len) {
dd("found exptime: %s", exptime_vv->data);

len += sizeof(' ') + exptime_vv->len;
len += sizeof(" ") - 1 + exptime_vv->len;
}

len += sizeof(CRLF) - 1;
Expand Down Expand Up @@ -531,8 +531,8 @@ ngx_http_memc_create_incr_decr_cmd_request(ngx_http_request_t *r)

/* XXX validate if $memc_value_vv is a valid uint64 string */

len = ctx->cmd_str.len + sizeof(' ') + key_vv->len + escape
+ sizeof(' ') + value_vv->len + sizeof(CRLF) - 1;
len = ctx->cmd_str.len + sizeof(" ") - 1 + key_vv->len + escape
+ sizeof(" ") - 1 + value_vv->len + sizeof(CRLF) - 1;

b = ngx_create_temp_buf(r->pool, len);
if (b == NULL) {
Expand Down