Skip to content

SOFTWARE-6232: htcondor2 bindings#193

Merged
brianhlin merged 6 commits into
opensciencegrid:2.xfrom
mwestphall:SOFTWARE-6232-htcondor2-bindings
Oct 14, 2025
Merged

SOFTWARE-6232: htcondor2 bindings#193
brianhlin merged 6 commits into
opensciencegrid:2.xfrom
mwestphall:SOFTWARE-6232-htcondor2-bindings

Conversation

@mwestphall
Copy link
Copy Markdown
Contributor

No description provided.

@mwestphall mwestphall requested a review from brianhlin October 13, 2025 21:07
Copy link
Copy Markdown
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer leaving the osg-pilot-container probe alone until we have a plan. Also, we should bump the condor requirement on gratia-probe condor subpackages so that they pull in a version with htcondor2 available. I think that's 24.0.0 at a minimum but it's not clear from the upstream release notes when exactly they declared it ready.

Comment thread osg-pilot-container/osgpilot_meter Outdated
Comment thread osg-pilot-container/osgpilot_meter Outdated
@brianhlin
Copy link
Copy Markdown
Member

It looks like we need to import the htcondor2/classad2 python libraries into the tests

@mwestphall mwestphall requested a review from brianhlin October 14, 2025 14:00
@brianhlin
Copy link
Copy Markdown
Member

@mwestphall : Jason had a good idea in that we could try importing the new libraries and fallback to the old ones if that doesn't work. That way we can 1) get rid of the version requirement and 2) ship this in 24-main

@mwestphall
Copy link
Copy Markdown
Contributor Author

@brianhlin good idea. I've updated the package proper to use try-importing, I don't think it will be necessary for the tests since they are now just pulling in the htcondor2 python packages.

Copy link
Copy Markdown
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianhlin brianhlin merged commit b8be6d7 into opensciencegrid:2.x Oct 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants