Skip to content

set CI builds to rust debug build#21503

Open
mch2 wants to merge 1 commit intoopensearch-project:mainfrom
mch2:debugmode
Open

set CI builds to rust debug build#21503
mch2 wants to merge 1 commit intoopensearch-project:mainfrom
mch2:debugmode

Conversation

@mch2
Copy link
Copy Markdown
Member

@mch2 mch2 commented May 6, 2026

Description

These builds take forever...

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2 mch2 requested review from a team, jed326 and peternied as code owners May 6, 2026 05:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit b67d6dd.

PathLineSeverityDescription
.github/workflows/sandbox-check.yml36lowAddition of `-PrustDebug` Gradle property flag enables debug mode for Rust components in CI. While this likely reflects a legitimate intent to build Rust artifacts in debug mode, enabling debug builds in a CI check workflow is slightly anomalous — debug binaries may include additional symbols or relaxed optimizations. No evidence of malicious intent; maintainers should confirm this is an expected build configuration change.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 0 | Medium: 0 | Low: 1


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Debug Build Risk

The -PrustDebug flag enables a Rust debug build in CI. Debug builds are significantly slower to execute and produce larger binaries, which may impact CI performance and artifact size. Additionally, if this flag is intended only for temporary use to speed up compilation time, it should not be merged into the main branch as it could mask performance-related issues that only appear in release builds.

run: ./gradlew check -p sandbox -Dsandbox.enabled=true -PrustDebug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant