Skip to content

Sigstore sign release payloads prior to adding to the release controller #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 11, 2024
Merged

Sigstore sign release payloads prior to adding to the release controller #689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pyartcd/pyartcd/pipelines/promote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,14 @@ async def run(self):
pullspecs_repr = ", ".join(f"{arch}: {pullspecs[arch]}" for arch in sorted(pullspecs.keys()))
self._logger.info("All release images for %s have been promoted. Pullspecs: %s", release_name, pullspecs_repr)

# Signing payloads prior to adding it to the release controller assures that we are testing
# signature verification processes in an installing/running cluster. In the future, we might
# want to sign with a beta key before being accepted, so we don't gold sign all named releases,
# however, ClusterImagePolicy/ImagePolicy CRDs presently only support one public key per
# registry location.
if not self.skip_sigstore:
await self.sigstore_sign(release_name, release_infos)

# Before waiting for release images to be accepted by release controllers,
# we can start microshift build
await self._build_microshift(releases_config)
Expand Down Expand Up @@ -404,8 +412,6 @@ async def run(self):
lock_name=lock.value.format(signing_env=self.signing_env),
lock_id=lock_identifier
)
if not self.skip_sigstore:
await self.sigstore_sign(release_name, release_infos)

except Exception as err:
self._logger.exception(err)
Expand Down