config/v1/types_cluster_operator: Fix "spec hold the" typo #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
wking
force-pushed
the
cluster-operator-spec-hold-typo
branch
from
825de45 to
f9361ff
Compare
Contributor
|
/lgtm |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
The typo was originally from 898d7e3 (api: Move ClusterVersion/ClusterOperator into config.openshift.io, 2018-11-09, openshift#127). The "any operator" bit explains why we don't want, for example, ingress-operator specific config in here. The later ClusterOperatorSpec comment goes into more detail on that with its 'pause' hypothetical, but a bit of extra hinting can't hurt ;).
wking
force-pushed
the
cluster-operator-spec-hold-typo
branch
from
f9361ff to
c6fbb2d
Compare
Member
Author
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, smarterclayton, soltysh, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typo was originally from 898d7e3 (#127). The "any operator" bit explains why we don't want, for example, ingress-operator specific config in here. The later
ClusterOperatorSpeccomment goes into more detail on that with itspausehypothetical, but a bit of extra hinting can't hurt ;).