Skip to content

config/v1/types_cluster_operator: ClusterOperatorStatus doc wordsmithing #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 5, 2019
Merged

config/v1/types_cluster_operator: ClusterOperatorStatus doc wordsmithing #501

openshift-merge-robot merged 1 commit into from
Nov 5, 2019

Conversation

@wking
Copy link
Member

@wking wking commented Oct 28, 2019

Leaning heavily on the CVO docs.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2019
@wking wking mentioned this pull request Oct 28, 2019
Merged
soltysh
soltysh approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is improving docs and oc explain at the same time.
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit 21e87c8 into openshift:master Nov 5, 2019
@wking wking deleted the cluster-operator-status-condition-copy-edits branch November 6, 2019 00:27
wking added a commit to wking/openshift-api that referenced this pull request Nov 6, 2019
@wking
config/v1/types_cluster_operator: Fix "Degraded indicated" -> "Degrad…
6ffedc3 
…ed indicates"

And drop the earlier, orphaned comment block.  Both of these issues
slipped through my earlier 40c55f8
(config/v1/types_cluster_operator: ClusterOperatorStatus doc
wordsmithing, 2019-10-28, openshift#501).
@wking wking mentioned this pull request Nov 6, 2019
Merged
abhat pushed a commit to abhat/api that referenced this pull request Nov 25, 2019
@wking @abhat
config/v1/types_cluster_operator: Fix "Degraded indicated" -> "Degrad…
cc82e4b 
…ed indicates"

And drop the earlier, orphaned comment block.  Both of these issues
slipped through my earlier 40c55f8
(config/v1/types_cluster_operator: ClusterOperatorStatus doc
wordsmithing, 2019-10-28, openshift#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 22, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
5de0be4 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 22, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
bf9d403 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 23, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
f1ead17 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 23, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
16dbccb 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 23, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
56a2344 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 23, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
3fad9d4 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 29, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
6c6723c 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 29, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
f444e61 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 30, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
d795c57 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Mar 30, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
51a458c 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Apr 8, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
49284a2 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
wking added a commit to wking/cluster-version-operator that referenced this pull request Aug 6, 2021
@wking
pkg/cvo/metrics: Use name == "operator" for cluster_operator_up
37bf742 
Fixing a TODO from 02a389b (sync: Temporarily stop checking version
in ClusterOperator.Status, 2019-01-23, openshift#98).  The semantics of the
'operator' entry have been clear since at least
openshift/api@40c55f8085 (config/v1/types_cluster_operator:
ClusterOperatorStatus doc wordsmithing, 2019-10-28,
openshift/api#501).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @openshift-ci-robot @soltysh @openshift-merge-robot