Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Mar 14, 2020

Expanding on the links from b1465b7 (#87).

Port bug:

  • 4.4.0: rhbz#1801300, Bug 1801300: lib/resourcemerge: remove ports which are no longer required cluster-version-operator#322 which made it into 4.4.0-rc.0:

    $ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.4.0-rc.0-x86_64 | grep cluster-version
      cluster-version-operator                       https://github.com/openshift/cluster-version-operator                       23856901003b95b559087b8e83bffdee82872b2b
    $ git --no-pager log --oneline --first-parent -6 origin/release-4.4
    2385690 (origin/release-4.4) Merge pull request #332 from openshift-cherrypick-robot/cherry-pick-328-to-release-4.4
    ...
    2df3d56 Merge pull request #322 from vrutkovs/remove-outdated-ports
  • 4.3.z: rbhz#1802710 Bug 1802710: lib/resourcemerge: remove ports which are no longer required cluster-version-operator#323 which made it into 4.3.3:

    $ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.3.3-x86_64 | grep cluster-version
      cluster-version-operator                      https://github.com/openshift/cluster-version-operator                      210b4b1e6b1b7f53b5dc0d935de9c5d27058280c
    $ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.3.2-x86_64 | grep cluster-version
      cluster-version-operator                      https://github.com/openshift/cluster-version-operator                      beee410fc8780e5613c09fc2690716b711747041
    $ git --no-pager log --oneline --first-parent -5 origin/release-4.3
    210b4b1 (origin/release-4.3) Merge pull request #321 from openshift-cherrypick-robot/cherry-pick-319-to-release-4.3
    5057680 Merge pull request #323 from vrutkovs/4.3-container-ports
    ...
    beee410 Merge pull request #290 from wking/no-ephemeral-storage-in-4.2-so-4.3-cannot-rely-on-it
  • 4.2.z: rhbz#1802248 Bug 1802248: lib/resourcemerge: remove ports which are no longer required cluster-version-operator#325 which made it into 4.2.21:

    $ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.2.21-x86_64 | grep cluster-version
      cluster-version-operator                      https://github.com/openshift/cluster-version-operator                      ccbed39b6faab201a1bafc49a7f519194d5dd548
    $ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.2.20-x86_64 | grep cluster-version
      cluster-version-operator                      https://github.com/openshift/cluster-version-operator                      9f4f04e736a0bbc61323593fbb62874570f07762
    $ git --no-pager log --oneline --first-parent -4 origin/release-4.2
    4b39863 (origin/release-4.2) Merge pull request #314 from wking/resource-merge-index-mutating-existing-4.2
    ccbed39 Merge pull request #300 from openshift-cherrypick-robot/cherry-pick-298-to-release-4.2
    a8ed501 Merge pull request #325 from vrutkovs/4.2-container-ports
    9f4f04e Merge pull request #288 from wking/no-ephemeral-storage-in-4.2
  • autoscaler and machine-API operator both removed their metrics port in 4.2 -> 4.3. So 4.2 clusters which update to 4.3 < 4.3.5 will hit this.

  • ingress operator removed its metrics port in 4.1 -> 4.2, so 4.1 clusters which update to 4.2 < 4.2.21 will hit this.

Multus bug:

  • 4.5.0: rhbz#1805987

  • 4.4.0: rhbz#1805774 Bug 1805774: Use the readiness indicator file option for Multus cluster-network-operator#507 Bug 1805774: Exposes readinessindicatorfile and uses wait.PollImmediate [backport 4.4] multus-cni#49 which made it into 4.4.0-rc.0:

    $ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.4.0-rc.0-x86_64 | grep 'network-operator\|multus-cni'
      cluster-network-operator                       https://github.com/openshift/cluster-network-operator                       983f31b7c4a207542bb71b8221addf82a954c6e0
      multus-cni                                     https://github.com/openshift/multus-cni                                     384bc19c84d2da109f9a5e30367c86bf32ad4e51
    cluster-network-operator$ git --no-pager log --oneline --first-parent -5 origin/release-4.4
    c4ee5bbd (origin/release-4.4) Merge pull request #518 from openshift-cherrypick-robot/cherry-pick-516-to-release-4.4
    983f31b7 Merge pull request #514 from pecameron/cp500.4.4
    ...
    53afa956 Merge pull request #507 from danwinship/add-readiness-indicator-4.4
    multus-cni$ git --no-pager log --oneline --first-parent -1 origin/release-4.4
    384bc19c (origin/release-4.4) Merge pull request #53 from dougbtv/no-config-invalidation-44
  • 4.3.z: https://bugzilla.redhat.com/show_bug.cgi?id=1805444 Bug 1805444: Uses the readiness indicator file option for Multus [backport 4.3] cluster-network-operator#485 Bug 1805444: Exposes readinessindicatorfile and uses wait.PollImmediate [backport 4.3] multus-cni#48 which made it into 4.3.5 (4.3.4 doesn't exist):

    $ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.3.5-x86_64 | grep 'network-operator\|multus-cni'
      cluster-network-operator                      https://github.com/openshift/cluster-network-operator                      93c9431b9f5160cc620bba93a6f59e2525a54e2c
      multus-cni                                    https://github.com/openshift/multus-cni                                    50acccef844042b0bc3ffe5f243cb2e13647d07d
    $ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.3.3-x86_64 | grep 'network-operator\|multus-cni'
      cluster-network-operator                      https://github.com/openshift/cluster-network-operator                      3e76a1ef1dccac9b44bdbd00ff145b2a1abe611a
      multus-cni                                    https://github.com/openshift/multus-cni                                    1cb7d0f9c0a336ba7f33a0e2800c12205f10878c
    cluster-network-operator$ git --no-pager log --oneline --first-parent -9 origin/release-4.3
    3af6eeb4 (origin/release-4.3) Merge pull request #526 from dougbtv/reintroduce-whereabouts-routeoverride-43
    ...
    93c9431b Merge pull request #504 from juanluisvaladas/fix-noproxy-43
    7ae0b7e8 Merge pull request #485 from dougbtv/add-readiness-indicator-43
    ...
    3e76a1ef Merge pull request #470 from alexanderConstantinescu/bugfix/fix_ovn_controller_rbac
    multus-cni$ git --no-pager log --oneline --first-parent -3 origin/release-4.3
    9e85cb1b (origin/release-4.3) Merge pull request #52 from dougbtv/no-config-invalidation-43
    50acccef Merge pull request #48 from dougbtv/readiness-indicator-poll-43
    1cb7d0f9 Merge pull request #40 from dougbtv/rhel8-set-commit
  • Not backported to 4.2.z. It's not clear to me what the situation on 4.2 is. Also not clear to me what sort of updates would trigger this issue; whether it is all *-> into broken releases? Just 4.2 -> broken 4.3? Broken 4.2 -> any 4.3? For now I'll just assume that 4.2 is not affected and * -> broken 4.3 is the only vulnerable case.

Memory leak:

Also, no need to talk about these in the channel YAML files, since we aren't tombstoning the releases (we discovered the bug after marking the releases supported by tagging them into fast channels).

Also block * -> 4.3 for 4.3 before 4.3.5, now that we have the Multus bug to worry about. 4.2 -> 4.3.1 had been blocked before, although that block was lifted in c641bbd (#60). This isolates the two 4.3 RCs, but we don't commit to providing updates out of candidate releases anway. If we get pushback on that (unlikely now that 4.3 has been GA for so long), we can add rc -> 4.3.6 update edges or some such.

@wking wking force-pushed the expand-motivation-for-4.3.3-blocks branch from f9b5e72 to 8dcce54 Compare March 14, 2020 07:14
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 14, 2020
As described in 8dcce54 (blocked-edges: Details on bugs for 4.3.2
and 4.3.3, 2020-03-14, openshift#119), for the ingress operator metric port
removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 14, 2020
As described in 8dcce54 (blocked-edges: Details on bugs for 4.3.2
and 4.3.3, 2020-03-14, openshift#119), for the ingress operator metric port
removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.
@wking wking force-pushed the expand-motivation-for-4.3.3-blocks branch from 76d1f57 to 0c3d18a Compare March 14, 2020 07:35
@wking
Copy link
Member Author

wking commented Mar 14, 2020

Also block 4.1 -> 4.2 until 4.2.21, for the ingress operator metric port removal in 4.1 -> 4.2.

@wking wking force-pushed the expand-motivation-for-4.3.3-blocks branch from 0c3d18a to 2f347a8 Compare March 14, 2020 07:39
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 14, 2020
As described in 8dcce54 (blocked-edges: Details on bugs for 4.3.2
and 4.3.3, 2020-03-14, openshift#119), for the ingress operator metric port
removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.
@wking wking force-pushed the expand-motivation-for-4.3.3-blocks branch from 2f347a8 to 1b6af73 Compare March 14, 2020 07:53
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 14, 2020
As described in 8dcce54 (blocked-edges: Details on bugs for 4.3.2
and 4.3.3, 2020-03-14, openshift#119), for the ingress operator metric port
removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.
@wking
Copy link
Member Author

wking commented Mar 14, 2020

@sdodson dropped UpdateBlocker from the memory-leak bug and it seems like a non-regression that is not update-specific, so I've pushed 2f347a8 -> 1b6af73 to remove references to this series from blocked-edges.

@wking wking force-pushed the expand-motivation-for-4.3.3-blocks branch from 1b6af73 to b10bb03 Compare March 16, 2020 19:44
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 16, 2020
As described in 8dcce54 (blocked-edges: Details on bugs for 4.3.2
and 4.3.3, 2020-03-14, openshift#119), for the ingress operator metric port
removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.
@wking
Copy link
Member Author

wking commented Mar 16, 2020

Multus series was only a minute or so of unreachable workloads, after which the issue resolves automatically. I dropped UpgradeBlocker from the 4.3 bug here, because we have been accepting brief workload unreachability since #40. I've updated this PR to remove Multus references with 1b6af73 -> b10bb03. That means that with this PR, the only remaining issue is the container port series.

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Mar 19, 2020

Multus series was only a minute or so of unreachable workloads, after which the issue resolves automatically. I dropped UpgradeBlocker from the 4.3 bug here, because we have been accepting brief workload unreachability since #40. I've updated this PR to remove Multus references with 1b6af73 -> b10bb03. That means that with this PR, the only remaining issue is the container port series.

This is tricky. We found one issue, somehow we did a wrong diagnosis that it is an upgrade blocker. We blocked the edges as per the wrong diagnosis. Now we want to correct this in the files. I am sure this will happen in future too.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@wking wking force-pushed the expand-motivation-for-4.3.3-blocks branch from b10bb03 to ce7fc11 Compare March 19, 2020 21:01
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 19, 2020
As described in 8dcce54 (blocked-edges: Details on bugs for 4.3.2
and 4.3.3, 2020-03-14, openshift#119), for the ingress operator metric port
removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@wking
Copy link
Member Author

wking commented Mar 19, 2020

Rebased around #127 with b10bb03 -> ce7fc11. No conflicts other than removing the RC blocked edges (motivation in fe0dfa3, #127).

@wking wking force-pushed the expand-motivation-for-4.3.3-blocks branch from ce7fc11 to d9af1c2 Compare March 19, 2020 21:42
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 19, 2020
As described in 8dcce54 (blocked-edges: Details on bugs for 4.3.2
and 4.3.3, 2020-03-14, openshift#119), for the ingress operator metric port
removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 19, 2020
As described in 3a903e1 (blocked-edges: Details on bugs for 4.3.2
and 4.3.3, 2020-03-14, openshift#119), for the ingress operator metric port
removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.
@wking wking force-pushed the expand-motivation-for-4.3.3-blocks branch from d9af1c2 to 5252c62 Compare March 19, 2020 21:43
wking added 4 commits March 20, 2020 15:47
This was originally from b1465b7 (Information on why 4.3.2 and
4.3.3 not in fast and stable channels of 4.3, 2020-03-03, #87), but
upon further review it is not severe enough to warrant blocked edges
or promotions [1].

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1805444#c9
This was originally from b1465b7 (Information on why 4.3.2 and
4.3.3 not in fast and stable channels of 4.3, 2020-03-03, #87), but
upon further review it is not a regression and so does not warrant
blocked edges or promotions [1].

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1808429#c6
Expanding on the link from b1465b7 (Information on why 4.3.2 and
4.3.3 not in fast and stable channels of 4.3, 2020-03-03, #87).
Coarse blocks landed in 1161d00 (Added 4.3.2->4.3.3 to channels,
2020-03-06, openshift#100), but the leak only affects 4.y -> 4.(y+1) updates,
since those are the only transitions where manifests dropped container
ports [1].

Block 4.2 -> 4.3 for 4.3 before 4.3.5 because of the port bug.  4.2 ->
4.3.1 had been blocked before, although that block was lifted in
c641bbd (channels/fast-4.2: Promote 4.2.18 (and 4.2.18+amd64 to
fast-4.3), 2020-02-19, #60).  I think 1161d00's broader .* blocks
(which I'm relaxing to 4.2.* blocks) on the earlier 4.3 releases were
because the Multus bug affects all updates, but, as explained in
a5f394d (blocked-edges/4.3.*: Drop references to Multus bug
1805444, 2020-03-20, openshift#119), the Multus bug is actually not an update
blocker.

Also, no need to talk about these in the channel YAML files, since we
aren't tombstoning the releases (we discovered the bug after marking
the releases supported by tagging them into fast channels).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
As described in b86ce4d (blocked-edges/4.3.*: Clarify effect of
container-port leak (bug 1801300), 2020-03-13, openshift#119) and [1,2], for
the ingress operator metric port removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1802248#c3
@wking wking force-pushed the expand-motivation-for-4.3.3-blocks branch from 8be4df4 to 0e97e6a Compare March 20, 2020 22:48
@wking
Copy link
Member Author

wking commented Mar 20, 2020

Nothing in 4.3 -> 4.3.2 in Telemetry in the past week, so no known problems there. #100 doesn't actually describe 4.3 -> 4.3.2 or 4.3.3 failures that would call for blocking the edges. 4.3.2 was added to candidate in #51, which mentions concerns with 4.2 -> 4.3.2, but nothing about 4.3 -> 4.3.2. 4.3 -> 4.3.2 CI only covered 4.3.1 -> 4.3.2, leaving out 4.3.0 -> 4.3.2:

$ oc adm release info quay.io/openshift-release-dev/ocp-release:4.3.2-x86_64 | grep Upgrades
  Upgrades: 4.2.19, 4.3.0, 4.3.1

4.3.1 -> 4.3.2 CI had two successes (both AWS) and four failures (all Boskos CI flakes, so no bearing on update success). We could launch more CI coverage, but...

There have been only two 4.3 -> 4.3.3 updates in Telemetry in the past week, both successful (4.3.2->4.3.3 and, !, 4.3.5 -> 4.3.3). Updates to 4.3.3 have good CI coverage, discussed in #57. Lots of bugs linked from discussion there. Going through them again, rhbz#1809296 seams severe enough to warrant blocking 4.3->4.3 until the fix landed in 4.3.5. So I've reshuffled here to:

$ git --no-pager log --format='%h %s' origin/master..origin/pr/119
8be4df4 blocked-edges/4.2.*: Clarify effect of container-port leak (bug 1801300)
fcd2173 blocked-edges/4.3.*: Clarify effect of container-port leak (bug 1801300)
da5fe88 blocked-edges: Drop references to memory-leak bug 1808429
c239177 blocked-edges/4.3.*: Drop references to Multus bug 1805444
d14b4ad blocked-edges/4.3*: Block 4.3 -> 4.3 until 4.3 -> 4.3.5 for bug 1809296

That's enough so that this PR will no longer expose any new edges (it only removes edges).

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2020
@vrutkovs
Copy link

/approve

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@eparis
Copy link
Member

eparis commented Mar 24, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, LalatenduMohanty, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3a4f1a8 into openshift:master Mar 24, 2020
@wking wking deleted the expand-motivation-for-4.3.3-blocks branch March 24, 2020 17:25
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Apr 16, 2020
I'm not clear on when this was introduced, but we saw it in 4.3.2 ->
4.3.3 CI [1] and it wasn't fixed until 4.3.5 [2].  It's not clear to
me if this is a regression or not, and we usually don't pull
edges/releases unless an issue is a regression.  But there is some
concern about restoring 4.3 -> 4.3 edges [3], and leaning on this
fixed-in-4.3.5 issue gives us some grounds for continuing to block 4.3
-> 4.3.2 and 4.3 -> 4.3.3.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774212#c7
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1809296#c10
[3]: openshift#119 (review)
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Apr 16, 2020
Expanding on the link from b1465b7 (Information on why 4.3.2 and
4.3.3 not in fast and stable channels of 4.3, 2020-03-03, openshift#87).
Coarse blocks landed in 1161d00 (Added 4.3.2->4.3.3 to channels,
2020-03-06, openshift#100), but the leak only affects 4.y -> 4.(y+1) updates,
since those are the only transitions where manifests dropped container
ports [1].

Block 4.2 -> 4.3 for 4.3 before 4.3.5 because of the port bug.  4.2 ->
4.3.1 had been blocked before, although that block was lifted in
c641bbd (channels/fast-4.2: Promote 4.2.18 (and 4.2.18+amd64 to
fast-4.3), 2020-02-19, openshift#60).  I think 1161d00's broader .* blocks
(which I'm relaxing to 4.2.* blocks) on the earlier 4.3 releases were
because the Multus bug affects all updates, but, as explained in
a5f394d (blocked-edges/4.3.*: Drop references to Multus bug
1805444, 2020-03-20, openshift#119), the Multus bug is actually not an update
blocker.

Also, no need to talk about these in the channel YAML files, since we
aren't tombstoning the releases (we discovered the bug after marking
the releases supported by tagging them into fast channels).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Apr 16, 2020
As described in b86ce4d (blocked-edges/4.3.*: Clarify effect of
container-port leak (bug 1801300), 2020-03-13, openshift#119) and [1,2], for
the ingress operator metric port removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1802248#c3
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 14, 2020
I'm not clear on when this was introduced, but we saw it in 4.3.2 ->
4.3.3 CI [1] and it wasn't fixed until 4.3.5 [2].  It's not clear to
me if this is a regression or not, and we usually don't pull
edges/releases unless an issue is a regression.  But there is some
concern about restoring 4.3 -> 4.3 edges [3], and leaning on this
fixed-in-4.3.5 issue gives us some grounds for continuing to block 4.3
-> 4.3.2 and 4.3 -> 4.3.3.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774212#c7
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1809296#c10
[3]: openshift#119 (review)
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 14, 2020
Expanding on the link from b1465b7 (Information on why 4.3.2 and
4.3.3 not in fast and stable channels of 4.3, 2020-03-03, openshift#87).
Coarse blocks landed in 1161d00 (Added 4.3.2->4.3.3 to channels,
2020-03-06, openshift#100), but the leak only affects 4.y -> 4.(y+1) updates,
since those are the only transitions where manifests dropped container
ports [1].

Block 4.2 -> 4.3 for 4.3 before 4.3.5 because of the port bug.  4.2 ->
4.3.1 had been blocked before, although that block was lifted in
c641bbd (channels/fast-4.2: Promote 4.2.18 (and 4.2.18+amd64 to
fast-4.3), 2020-02-19, openshift#60).  I think 1161d00's broader .* blocks
(which I'm relaxing to 4.2.* blocks) on the earlier 4.3 releases were
because the Multus bug affects all updates, but, as explained in
a5f394d (blocked-edges/4.3.*: Drop references to Multus bug
1805444, 2020-03-20, openshift#119), the Multus bug is actually not an update
blocker.

Also, no need to talk about these in the channel YAML files, since we
aren't tombstoning the releases (we discovered the bug after marking
the releases supported by tagging them into fast channels).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 14, 2020
As described in b86ce4d (blocked-edges/4.3.*: Clarify effect of
container-port leak (bug 1801300), 2020-03-13, openshift#119) and [1,2], for
the ingress operator metric port removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1802248#c3
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 29, 2020
I'm not clear on when this was introduced, but we saw it in 4.3.2 ->
4.3.3 CI [1] and it wasn't fixed until 4.3.5 [2].  It's not clear to
me if this is a regression or not, and we usually don't pull
edges/releases unless an issue is a regression.  But there is some
concern about restoring 4.3 -> 4.3 edges [3], and leaning on this
fixed-in-4.3.5 issue gives us some grounds for continuing to block 4.3
-> 4.3.2 and 4.3 -> 4.3.3.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774212#c7
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1809296#c10
[3]: openshift#119 (review)
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 29, 2020
Expanding on the link from b1465b7 (Information on why 4.3.2 and
4.3.3 not in fast and stable channels of 4.3, 2020-03-03, openshift#87).
Coarse blocks landed in 1161d00 (Added 4.3.2->4.3.3 to channels,
2020-03-06, openshift#100), but the leak only affects 4.y -> 4.(y+1) updates,
since those are the only transitions where manifests dropped container
ports [1].

Block 4.2 -> 4.3 for 4.3 before 4.3.5 because of the port bug.  4.2 ->
4.3.1 had been blocked before, although that block was lifted in
c641bbd (channels/fast-4.2: Promote 4.2.18 (and 4.2.18+amd64 to
fast-4.3), 2020-02-19, openshift#60).  I think 1161d00's broader .* blocks
(which I'm relaxing to 4.2.* blocks) on the earlier 4.3 releases were
because the Multus bug affects all updates, but, as explained in
a5f394d (blocked-edges/4.3.*: Drop references to Multus bug
1805444, 2020-03-20, openshift#119), the Multus bug is actually not an update
blocker.

Also, no need to talk about these in the channel YAML files, since we
aren't tombstoning the releases (we discovered the bug after marking
the releases supported by tagging them into fast channels).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 29, 2020
As described in b86ce4d (blocked-edges/4.3.*: Clarify effect of
container-port leak (bug 1801300), 2020-03-13, openshift#119) and [1,2], for
the ingress operator metric port removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1802248#c3
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Aug 24, 2020
I'm not clear on when this was introduced, but we saw it in 4.3.2 ->
4.3.3 CI [1] and it wasn't fixed until 4.3.5 [2].  It's not clear to
me if this is a regression or not, and we usually don't pull
edges/releases unless an issue is a regression.  But there is some
concern about restoring 4.3 -> 4.3 edges [3], and leaning on this
fixed-in-4.3.5 issue gives us some grounds for continuing to block 4.3
-> 4.3.2 and 4.3 -> 4.3.3.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774212#c7
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1809296#c10
[3]: openshift#119 (review)
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Aug 24, 2020
Expanding on the link from b1465b7 (Information on why 4.3.2 and
4.3.3 not in fast and stable channels of 4.3, 2020-03-03, openshift#87).
Coarse blocks landed in 1161d00 (Added 4.3.2->4.3.3 to channels,
2020-03-06, openshift#100), but the leak only affects 4.y -> 4.(y+1) updates,
since those are the only transitions where manifests dropped container
ports [1].

Block 4.2 -> 4.3 for 4.3 before 4.3.5 because of the port bug.  4.2 ->
4.3.1 had been blocked before, although that block was lifted in
c641bbd (channels/fast-4.2: Promote 4.2.18 (and 4.2.18+amd64 to
fast-4.3), 2020-02-19, openshift#60).  I think 1161d00's broader .* blocks
(which I'm relaxing to 4.2.* blocks) on the earlier 4.3 releases were
because the Multus bug affects all updates, but, as explained in
a5f394d (blocked-edges/4.3.*: Drop references to Multus bug
1805444, 2020-03-20, openshift#119), the Multus bug is actually not an update
blocker.

Also, no need to talk about these in the channel YAML files, since we
aren't tombstoning the releases (we discovered the bug after marking
the releases supported by tagging them into fast channels).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Aug 24, 2020
As described in b86ce4d (blocked-edges/4.3.*: Clarify effect of
container-port leak (bug 1801300), 2020-03-13, openshift#119) and [1,2], for
the ingress operator metric port removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1802248#c3
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Dec 3, 2020
I'm not clear on when this was introduced, but we saw it in 4.3.2 ->
4.3.3 CI [1] and it wasn't fixed until 4.3.5 [2].  It's not clear to
me if this is a regression or not, and we usually don't pull
edges/releases unless an issue is a regression.  But there is some
concern about restoring 4.3 -> 4.3 edges [3], and leaning on this
fixed-in-4.3.5 issue gives us some grounds for continuing to block 4.3
-> 4.3.2 and 4.3 -> 4.3.3.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774212#c7
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1809296#c10
[3]: openshift#119 (review)
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Dec 3, 2020
Expanding on the link from b1465b7 (Information on why 4.3.2 and
4.3.3 not in fast and stable channels of 4.3, 2020-03-03, openshift#87).
Coarse blocks landed in 1161d00 (Added 4.3.2->4.3.3 to channels,
2020-03-06, openshift#100), but the leak only affects 4.y -> 4.(y+1) updates,
since those are the only transitions where manifests dropped container
ports [1].

Block 4.2 -> 4.3 for 4.3 before 4.3.5 because of the port bug.  4.2 ->
4.3.1 had been blocked before, although that block was lifted in
c641bbd (channels/fast-4.2: Promote 4.2.18 (and 4.2.18+amd64 to
fast-4.3), 2020-02-19, openshift#60).  I think 1161d00's broader .* blocks
(which I'm relaxing to 4.2.* blocks) on the earlier 4.3 releases were
because the Multus bug affects all updates, but, as explained in
a5f394d (blocked-edges/4.3.*: Drop references to Multus bug
1805444, 2020-03-20, openshift#119), the Multus bug is actually not an update
blocker.

Also, no need to talk about these in the channel YAML files, since we
aren't tombstoning the releases (we discovered the bug after marking
the releases supported by tagging them into fast channels).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Dec 3, 2020
As described in b86ce4d (blocked-edges/4.3.*: Clarify effect of
container-port leak (bug 1801300), 2020-03-13, openshift#119) and [1,2], for
the ingress operator metric port removal from 4.1 -> 4.2.

Also SemVer sort the RC in candidate-4.2.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1801300#c35
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1802248#c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants