Skip to content

Conversation

@LalatenduMohanty
Copy link
Member

Signed-off-by: Lalatendu Mohanty [email protected]

Signed-off-by: Lalatendu Mohanty <[email protected]>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LalatenduMohanty
To complete the pull request process, please assign crawford
You can assign the PR to them by writing /assign @crawford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Mar 18, 2020

Do we believe these bugs are new in rc.1? Can you add notes about why they do not affect 4.3 -> rc.0 or rc.0 -> rc.1?

@wking
Copy link
Member

wking commented Mar 18, 2020

Wait, with #118 still open, we can just tombstone rc.1 without blocking edges.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
@wking
Copy link
Member

wking commented Mar 18, 2020

Maybe reroll to tombstone rc.1?

@wking
Copy link
Member

wking commented Mar 18, 2020

#127 tombstones rc.1 so it never lands in any channels.

/close

@openshift-ci-robot
Copy link

@wking: Closed this PR.

Details

In response to this:

#127 tombstones rc.1 so it never lands in any channels.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty
Copy link
Member Author

/reopen

@openshift-ci-robot
Copy link

@LalatenduMohanty: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty
Copy link
Member Author

/close

@openshift-ci-robot
Copy link

@LalatenduMohanty: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants