-
Notifications
You must be signed in to change notification settings - Fork 65
blocked-edges/4.2.23: Block all incoming edges on the service CA bug 1810036 #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-robot
merged 4 commits into
openshift:master
from
wking:expand-on-ca-rotation-blockage
Mar 19, 2020
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d544dde
blocked-edges/4.2.23: Block all incoming edges on the service CA bug …
wking 7c0b935
channels: Promote 4.2.23 to fast/stable-4.2 and (for amd64) to fast/s…
wking bfd8c4a
channels: Promote 4.4.0-rc.1 after all
wking fe0dfa3
blocked-edges: Drop blocked edges into RCs
wking File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
blocked-edges/4.2.23: Block all incoming edges on the service CA bug …
…1810036 The bugs were introduced by the [1] series, and fixed by the combination of [2,3]. This commit also tombstones affected releases to avoid further channel promotion. Quick overview: * 4.4: both rc.0 and rc.1 affected, so block updates into rc.0 and tombstone rc.1. Fixes have landed, so next 4.4 RC should be clean. * 4.3: 4.3.5 introduced the breakage, no fix yet. Block edges into 4.3.5 and tombstone 4.3.7. * 4.2: 4.2.22 introduced the breakage, no fix yet. Block edges into 4.2.22 and 4.2.23 and tombstone 4.2.24 * 4.1: not impacted yet. Bugzilla series that was backporting the breaking change is still ASSIGNED Reasoning behind the overview's claims in [4]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774121 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1810036 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1801573 [4]: https://bugzilla.redhat.com/show_bug.cgi?id=1810036#c11
- Loading branch information
commit d544dde9537a968d23fa700a7d91b06db0930cb6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Upgrading any release to 4.2.23 will enable automated service ca | ||
| # rotation without unique ca serial numbers. This will result in | ||
| # condition reported in the linked bz, and only be recoverable by | ||
| # manual service ca rotation. | ||
| # | ||
| # Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1810036 https://bugzilla.redhat.com/show_bug.cgi?id=1801573 | ||
| to: 4.2.23 | ||
| from: .* | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Upgrading any release to 4.4.0-rc.0 will enable automated service ca | ||
| # rotation without unique ca serial numbers. This will result in | ||
| # condition reported in the linked bz, and only be recoverable by | ||
| # manual service ca rotation. | ||
| # | ||
| # Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1810036 | ||
| to: 4.4.0-rc.0 | ||
| from: .* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| name: candidate-4.4 | ||
| versions: | ||
| - 4.3.5 | ||
| # No 4.3.6 because of https://bugzilla.redhat.com/show_bug.cgi?id=1811886 | ||
| # No 4.3.7 because of the service CA rotation issue: https://bugzilla.redhat.com/show_bug.cgi?id=1810036 https://bugzilla.redhat.com/show_bug.cgi?id=1801573 | ||
| - 4.4.0-rc.0 | ||
| # No 4.4.0-rc.1 because of the service CA rotation issue: https://bugzilla.redhat.com/show_bug.cgi?id=1810036 | ||
wking marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.2.23 is in stable-4.2, etc., so we do want to block the edge on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.