Skip to content

Conversation

@vfreex
Copy link
Contributor

@vfreex vfreex commented Mar 19, 2020

No description provided.

@LalatenduMohanty
Copy link
Member

I am not able to verify that 4.3 -> 4.4 update hangs on ClusterOperatorDegraded, NodeInstallerDegraded, RevisionControllerDegraded, TargetConfigControllerDegraded -> https://bugzilla.redhat.com/show_bug.cgi?id=1812584 (This is in verified state) is fixed in this build.

Also following bugs are not fixed in the build.

So we are fine introducing this build in candidate but we need to block the edge to this.

@wking
Copy link
Member

wking commented Mar 19, 2020

So we are fine introducing this build in candidate but we need to block the edge to this.

New discussion: we don't care about gating update edges in candidate channels, because the idea is to allow folks to experiment. Remove all blocked edges that only impact candidate channels.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@LalatenduMohanty
Copy link
Member

/lgtm

@wking
Copy link
Member

wking commented Mar 19, 2020

Needs a rebase around #127.

@sdodson sdodson force-pushed the candidate-4.4.0-rc.2 branch from 3e77e1d to 3dc9111 Compare March 19, 2020 23:55
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@sdodson
Copy link
Member

sdodson commented Mar 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@sdodson
Copy link
Member

sdodson commented Mar 19, 2020

Rebased.

@jwforres
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwforres, LalatenduMohanty, sdodson, vfreex, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6ef6964 into openshift:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants