Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Mar 31, 2020

It's been at least 24 days since the fast promotions landed, so finish the "phased rollout" and put them in stable.

The previous comments about "only valid into" were from 505f7a6 (#109), and I'm not clear on the motivation.

It's been at least 24 days since the fast promotions landed, so finish
the "phased rollout" and put them in stable.

* 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d
  (Merge pull request #73 from wking/4.2.16-to-fast-4.3, 2020-02-21).
* There was no 4.2.17 (no releases in the week after 4.2.16).
* 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4
  (Merge pull request #60 from wking/fast-4.2.18, 2020-02-20).
* 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05
  (Merge pull request #64 from thiagoalessio/fast-4.2, 2020-02-24).

The previous comments about "only valid into" were from 505f7a6
(Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear
on the motivation.
@wking
Copy link
Member Author

wking commented Mar 31, 2020

This PR does not add new 4.2 -> 4.3 edges, because the 4.3 releases old enough to list these 4.2 releases as update sources have already blocked all 4.2 -> 4.3 edges. Also, see the current fast-4.3 graph:

$ curl -sH 'Accept:application/json' 'https://api.openshift.com/api/upgrades_info/v1/graph?channel=fast-4.3&arch=amd64' | ~/src/openshift/cincinnati/hack/graph.sh | dot -Tpng >graph.png

graph

@sdodson
Copy link
Member

sdodson commented Mar 31, 2020

/lgtm
Works for me, brings fast-4.3 and stable-4.3 in line with one another.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@eparis
Copy link
Member

eparis commented Mar 31, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2020
@openshift-merge-robot openshift-merge-robot merged commit 20af4d3 into openshift:master Mar 31, 2020
@wking wking deleted the 4.2.18-stable-4.3 branch March 31, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants