Skip to content

Enable 4.3.29 in stable channel(s) #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 20, 2020
Merged

Enable 4.3.29 in stable channel(s) #316

openshift-merge-robot merged 1 commit into from
Jul 20, 2020

Conversation

@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jul 8, 2020

Please merge within 48 hours of https://errata.devel.redhat.com/advisory/56664 shipping live OR a Cincinnati-first release.

This should provide adequate soak time for fast channel PR #315

This PR will also enable upgrades from 4.3.29 to releases in stable-4.4

@openshift-bot openshift-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2020
@sdodson sdodson force-pushed the pr-stable-4.3.29 branch from 4b23a32 to d37aa5b Compare July 14, 2020 12:20
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2020
@sosiouxme
Copy link
Member

sosiouxme commented Jul 15, 2020

#337 modifies this - s390x 4.3.29 build is bad.

@sdodson sdodson force-pushed the pr-stable-4.3.29 branch 2 times, most recently from 5f5a4ff to 38007d5 Compare July 17, 2020 13:22
@sdodson
Copy link
Member

sdodson commented Jul 17, 2020

/assign @wking
/uncc @jwforres @LalatenduMohanty

@sdodson
Copy link
Member

sdodson commented Jul 17, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
@wking
Enable 4.3.29 in stable channel(s)
f557d56 
Trevor: Removing the comment about s390x and ppc64le from 49b990f
(block updates to 4.3.29 for s390x, 2020-07-15, #337) and 389419e
(blocked-edges/4.3.29+ppc64le: Block on rhbz#1855807 (CRI-O boot
trouble), 2020-07-16, #338).  With the edges blocked already, their
promotion to stable will not add update recommendations.  And with the
errata published, Red Hat has already declared them to be supported.
Putting them in stable alongside the functional amd64 release reflects
that declaration, and imperils nobody.
@wking wking force-pushed the pr-stable-4.3.29 branch from 38007d5 to f557d56 Compare July 20, 2020 04:27
@wking
Copy link
Member

wking commented Jul 20, 2020

I've pushed 38007d5 -> f557d56 dropping the comment about not promoting s390x and ppc64le, since we are promoting them too. Commit message for f557d56 explains why. Update health in Telemetry/Insights looks good, so this is ready to land. But I'm leaving off a /lgtm for now to let other folks weigh in on the s390x/ppc64le promotion.

@sdodson
Copy link
Member

sdodson commented Jul 20, 2020

/hold cancel

@sdodson
Copy link
Member

sdodson commented Jul 20, 2020

derp
/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2020
@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jul 20, 2020

/override ci/prow/publish

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 20, 2020

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/publish

Details

In response to this:

/override ci/prow/publish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e4be5fa into master Jul 20, 2020
@sdodson sdodson deleted the pr-stable-4.3.29 branch October 12, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sdodson sdodson

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-bot @sosiouxme @sdodson @wking @openshift-ci-robot @openshift-merge-robot